launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~james-w/launchpad/bpph-binary-file-urls into lp:launchpad

To: James Westby <jw+debian@xxxxxxxxxxxxxxx>
From: Jonathan Lange <jml@xxxxxxxxxxxxx>
Date: Wed, 21 Dec 2011 11:17:41 -0000
In-reply-to: <20111220220527.8407.2111.launchpad@ackee.canonical.com>
Reply-to: mp+86470@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Looks good to me. Didn't know a BPPH had theoretically multiple files. 

Can't see any introduced performance issues. ProxiedLibrarianFileAlias duplicates work by getting the canonical_url of the parent a lot, but since we're doing that already for source packages I can't see it being a burden here.


-- 
https://code.launchpad.net/~james-w/launchpad/bpph-binary-file-urls/+merge/86470
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~james-w/launchpad/bpph-binary-file-urls into lp:launchpad.

References

[Merge] lp:~james-w/launchpad/bpph-binary-file-urls into lp:launchpad
From: James Westby, 2011-12-20