launchpad-reviewers team mailing list archive

[Stuart Bishop <stuart.bishop@xxxxxxxxxxxxx>]

Stuart Bishop has proposed merging lp:~stub/launchpad/db-deploy into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #911417 in Launchpad itself: "Staging db restore fails on make -C database/replication stagingsetup"
  https://bugs.launchpad.net/launchpad/+bug/911417

For more details, see:
https://code.launchpad.net/~stub/launchpad/db-deploy/+merge/87572

Add more BAD_USERS, allowing known bad jobs to be killed during fastdowntime deployments.
-- 
https://code.launchpad.net/~stub/launchpad/db-deploy/+merge/87572
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stub/launchpad/db-deploy into lp:launchpad.

=== modified file 'database/schema/preflight.py'
--- database/schema/preflight.py	2011-12-30 06:47:17 +0000
+++ database/schema/preflight.py	2012-01-05 08:04:24 +0000
@@ -1,5 +1,5 @@
 #!/usr/bin/python2.6 -S
-# Copyright 2011 Canonical Ltd.  This software is licensed under the
+# Copyright 2011-2012 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Confirm the database systems are ready to be patched as best we can."""
@@ -56,6 +56,9 @@
 BAD_USERS = frozenset([
     'karma',  # Bug #863109
     'rosettaadmin',  # Bug #863122
+    'update-pkg-cache',  # Bug #912144
+    'process_death_row',  # Bug #912146
+    'langpack',  # Bug #912147
     ])
 
 # How lagged the cluster can be before failing the preflight check.