launchpad-reviewers team mailing list archive

Thread
Date

[Merge] lp:~stevenk/launchpad/remove-translations-js into lp:launchpad

To: mp+87933@xxxxxxxxxxxxxxxxxx
From: Steve Kowalik <stevenk@xxxxxxxxxx>
Date: Mon, 09 Jan 2012 13:48:29 -0000
Reply-to: mp+87933@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Steve Kowalik has proposed merging lp:~stevenk/launchpad/remove-translations-js into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/remove-translations-js/+merge/87933

Remove the devmode-only translations.js METAL macro.
-- 
https://code.launchpad.net/~stevenk/launchpad/remove-translations-js/+merge/87933
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/remove-translations-js into lp:launchpad.

=== modified file 'lib/lp/translations/templates/distribution-translations.pt'
--- lib/lp/translations/templates/distribution-translations.pt	2010-12-29 12:36:28 +0000
+++ lib/lp/translations/templates/distribution-translations.pt	2012-01-09 13:47:54 +0000
@@ -7,8 +7,6 @@
 
   <head>
   <div metal:fill-slot="head_epilogue">
-    <metal:translations-js
-      use-macro="context/@@+translations-macros/translations-js" />
     <metal:languages-table-js
       use-macro="context/@@+translations-macros/languages-table-js" />
     <tal:robots

=== modified file 'lib/lp/translations/templates/distroseries-translations.pt'
--- lib/lp/translations/templates/distroseries-translations.pt	2011-03-23 06:17:58 +0000
+++ lib/lp/translations/templates/distroseries-translations.pt	2012-01-09 13:47:54 +0000
@@ -6,8 +6,6 @@
 
   <head>
   <div metal:fill-slot="head_epilogue">
-    <metal:translations-js
-      use-macro="context/@@+translations-macros/translations-js" />
     <metal:languages-table-js
       use-macro="context/@@+translations-macros/languages-table-js" />
     <meta tal:condition="not:context/translations_usage/enumvalue:LAUNCHPAD"

=== modified file 'lib/lp/translations/templates/product-translations.pt'
--- lib/lp/translations/templates/product-translations.pt	2010-10-26 21:26:27 +0000
+++ lib/lp/translations/templates/product-translations.pt	2012-01-09 13:47:54 +0000
@@ -6,8 +6,6 @@
 
   <head>
   <div metal:fill-slot="head_epilogue">
-    <metal:translations-js
-      use-macro="context/@@+translations-macros/translations-js" />
     <metal:languages-table-js
       use-macro="context/@@+translations-macros/languages-table-js" />
     <tal:robots

=== modified file 'lib/lp/translations/templates/productseries-translations.pt'
--- lib/lp/translations/templates/productseries-translations.pt	2011-03-23 06:17:58 +0000
+++ lib/lp/translations/templates/productseries-translations.pt	2012-01-09 13:47:54 +0000
@@ -6,8 +6,6 @@
 
   <head>
   <div metal:fill-slot="head_epilogue">
-    <metal:translations-js
-      use-macro="context/@@+translations-macros/translations-js" />
     <metal:languages-table-js
       use-macro="context/@@+translations-macros/languages-table-js" />
     <tal:robots

=== modified file 'lib/lp/translations/templates/translations-macros.pt'
--- lib/lp/translations/templates/translations-macros.pt	2011-11-26 04:03:29 +0000
+++ lib/lp/translations/templates/translations-macros.pt	2012-01-09 13:47:54 +0000
@@ -156,15 +156,6 @@
 </metal:pofile-js-footer>
 
 
-<metal:translations-js define-macro="translations-js">
-      <script
-        type="text/javascript"
-        tal:condition="devmode"
-        tal:attributes="src string:${icingroot}/build/translations/translations.js">
-      </script>
-</metal:translations-js>
-
-
 <metal:languages-table-js define-macro="languages-table-js">
       <script type="text/javascript">
       LPS.use('lp.translations.languages', 'event', function(Y) {