launchpad-reviewers team mailing list archive

[Huw Wilkins <huw.wilkins@xxxxxxxxxxxxx>]

Huw Wilkins has proposed merging lp:~huwshimi/launchpad/bug-listing-two-line into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #907765 in Launchpad itself: "New bug list wraps title even when there is plenty of room left in line"
  https://bugs.launchpad.net/launchpad/+bug/907765

For more details, see:
https://code.launchpad.net/~huwshimi/launchpad/bug-listing-two-line/+merge/88350

Bug titles were wrapping too soon. This was because we tried to fit extra info on the first.

This branch moves extra info to a new line and gives the bug titles more space.

A large portion of the template was moved into a new div, requiring a change in indentation.
-- 
https://code.launchpad.net/~huwshimi/launchpad/bug-listing-two-line/+merge/88350
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~huwshimi/launchpad/bug-listing-two-line into lp:launchpad.

=== modified file 'lib/canonical/launchpad/icing/css/components/bug_listing.css'
--- lib/canonical/launchpad/icing/css/components/bug_listing.css	2011-12-21 06:19:51 +0000
+++ lib/canonical/launchpad/icing/css/components/bug_listing.css	2012-01-12 11:32:24 +0000
@@ -15,13 +15,10 @@
     float: left;
     padding-right: 10px;
     }
-div.buglisting-col2,
-div.buglisting-col3 {
+div.buglisting-col2 {
     float: left;
     margin-top: 2px;
-    }
-div.buglisting-col2 {
-    width: 40%;
+    width: 68%;
     }
 div#client-listing .status,
 div#client-listing .importance {
@@ -33,7 +30,7 @@
     line-height: 12px;
     text-align: center;
     margin: 5px 10px 0 0;
-}
+    }
 div#client-listing .importance {
     width: 65px;
     }

=== modified file 'lib/lp/bugs/templates/buglisting.mustache'
--- lib/lp/bugs/templates/buglisting.mustache	2011-12-20 00:00:03 +0000
+++ lib/lp/bugs/templates/buglisting.mustache	2012-01-12 11:32:24 +0000
@@ -22,60 +22,60 @@
             {{/show_id}}
             <a href="{{bug_url}}" class="bugtitle">{{title}}</a>
         </div>
-    </div>
-    <div class="buglisting-col3">
-        {{#show_targetname}}
-            <span class="{{bugtarget_css}} field">
-                {{bugtarget}}
-            </span>
-        {{/show_targetname}}
-        {{#show_milestone_name}}
-            <span class="sprite milestone field">
-                {{#milestone_name}}
-                {{milestone_name}}
-                {{/milestone_name}}
-                {{^milestone_name}}
-                No milestone set
-                {{/milestone_name}}
-            </span>
-        {{/show_milestone_name}}
-        {{#show_date_last_updated}}
-            <span class="sprite milestone field">
-                Last updated {{last_updated}}
-            </span>
-        {{/show_date_last_updated}}
-        {{#show_assignee}}
-            <span class="sprite person field">
-                {{#assignee}}Assignee: {{assignee}}{{/assignee}}
-                {{^assignee}}Assignee: None{{/assignee}}
-            </span>
-        {{/show_assignee}}
-        {{#show_reporter}}
-            <span class="sprite person field">
-                Reporter: {{reporter}}
-            </span>
-        {{/show_reporter}}
-        {{#show_datecreated}}
-            <span class="sprite milestone field">
-                {{age}}
-            </span>
-        {{/show_datecreated}}
-        {{#show_tag}}
-            <span class="field">Tags:
-              {{^has_tags}}None{{/has_tags}}
-              {{#tags}}
-                 <a href="{{url}}" class="tag">{{tag}}</a>&#160;
-              {{/tags}}
-            </span>
-        {{/show_tag}}
-        {{#show_heat}}
-            <span class="bug-heat-icons">
-                 {{{bug_heat_html}}}
-            </span>
-        {{/show_heat}}
-        <span class="bug-related-icons">
-            {{{badges}}}
-        </span>
+        <div class="buginfo-extra">
+            {{#show_targetname}}
+                <span class="{{bugtarget_css}} field">
+                    {{bugtarget}}
+                </span>
+            {{/show_targetname}}
+            {{#show_milestone_name}}
+                <span class="sprite milestone field">
+                    {{#milestone_name}}
+                    {{milestone_name}}
+                    {{/milestone_name}}
+                    {{^milestone_name}}
+                    No milestone set
+                    {{/milestone_name}}
+                </span>
+            {{/show_milestone_name}}
+            {{#show_date_last_updated}}
+                <span class="sprite milestone field">
+                    Last updated {{last_updated}}
+                </span>
+            {{/show_date_last_updated}}
+            {{#show_assignee}}
+                <span class="sprite person field">
+                    {{#assignee}}Assignee: {{assignee}}{{/assignee}}
+                    {{^assignee}}Assignee: None{{/assignee}}
+                </span>
+            {{/show_assignee}}
+            {{#show_reporter}}
+                <span class="sprite person field">
+                    Reporter: {{reporter}}
+                </span>
+            {{/show_reporter}}
+            {{#show_datecreated}}
+                <span class="sprite milestone field">
+                    {{age}}
+                </span>
+            {{/show_datecreated}}
+            {{#show_tag}}
+                <span class="field">Tags:
+                  {{^has_tags}}None{{/has_tags}}
+                  {{#tags}}
+                     <a href="{{url}}" class="tag">{{tag}}</a>&#160;
+                  {{/tags}}
+                </span>
+            {{/show_tag}}
+            {{#show_heat}}
+                <span class="bug-heat-icons">
+                     {{{bug_heat_html}}}
+                </span>
+            {{/show_heat}}
+            <span class="bug-related-icons">
+                {{{badges}}}
+            </span>
+        </div>
     </div>
 
   </div>