launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/buildout-change-yui into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/buildout-change-yui/+merge/88457

I have hit this bug a few times during the Thunderdome. What happens is that the yui top-level directory is removed and the yui version that is specified in versions.cfg is unpacked. The last thing the buildout recipe does is symlink icing/yui into yui/<unpacked yui directory>. The problem is if icing/yui already exists, ln will refuse to replace it, and buildout doesn't show the error.
-- 
https://code.launchpad.net/~stevenk/launchpad/buildout-change-yui/+merge/88457
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/buildout-change-yui into lp:launchpad.

=== modified file 'buildout.cfg'
--- buildout.cfg	2011-12-30 06:47:17 +0000
+++ buildout.cfg	2012-01-13 08:38:25 +0000
@@ -43,7 +43,7 @@
     rm -rf ${buildout:yui-directory}/yui-${versions:yui}/*
     tar -zxf download-cache/dist/yui-${versions:yui}.tar.gz \
         -C ${buildout:yui-directory}/yui-${versions:yui}
-    ln -s ../../../../${buildout:yui-directory}/yui-${versions:yui} \
+    ln -sf ../../../../${buildout:yui-directory}/yui-${versions:yui} \
         lib/canonical/launchpad/icing/yui
 
 [filetemplates]