launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/fix-broken-js into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/fix-broken-js/+merge/88526

Fix five broken Javascript files that were found during the combo-loader death march.
-- 
https://code.launchpad.net/~stevenk/launchpad/fix-broken-js/+merge/88526
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/fix-broken-js into lp:launchpad.

=== modified file 'lib/lp/app/javascript/configutils.js'
--- lib/lp/app/javascript/configutils.js	2011-12-16 03:40:04 +0000
+++ lib/lp/app/javascript/configutils.js	2012-01-13 16:22:25 +0000
@@ -1,6 +1,6 @@
 /* Copyright (c) 2011, Canonical Ltd. All rights reserved. */
 
-YUI().add('lp.configutils', function(Y) {
+YUI.add('lp.configutils', function(Y) {
     /**
      * The configutils module provides objects for managing the config
      * or settings of a web page or widget.

=== modified file 'lib/lp/app/javascript/indicator/indicator.js'
--- lib/lp/app/javascript/indicator/indicator.js	2011-12-16 06:24:31 +0000
+++ lib/lp/app/javascript/indicator/indicator.js	2012-01-13 16:22:25 +0000
@@ -11,7 +11,7 @@
  *     });
  *
  */
-YUI().add('lp.indicator', function (Y) {
+YUI.add('lp.indicator', function (Y) {
 
     var props = {
         ATTRS: {

=== modified file 'lib/lp/app/javascript/lp-names.js'
--- lib/lp/app/javascript/lp-names.js	2011-06-21 05:37:38 +0000
+++ lib/lp/app/javascript/lp-names.js	2012-01-13 16:22:25 +0000
@@ -119,4 +119,4 @@
 }
 namespace.css_to_launchpad = css_to_launchpad;
 
-}, "0.1", {});
+}, "0.1", {"requires": []});

=== modified file 'lib/lp/app/javascript/ordering/ordering.js'
--- lib/lp/app/javascript/ordering/ordering.js	2011-12-21 13:23:46 +0000
+++ lib/lp/app/javascript/ordering/ordering.js	2012-01-13 16:22:25 +0000
@@ -1,6 +1,6 @@
 /* Copyright (c) 2011, Canonical Ltd. All rights reserved. */
 
-YUI().add('lp.ordering', function(Y) {
+YUI.add('lp.ordering', function(Y) {
     /**
      * A menu bar for quickly reordering a list of items on a page.
      * This widget is used for managing the bar, it's buttons, and

=== modified file 'lib/lp/bugs/javascript/buglisting_utils.js'
--- lib/lp/bugs/javascript/buglisting_utils.js	2011-12-21 13:23:46 +0000
+++ lib/lp/bugs/javascript/buglisting_utils.js	2012-01-13 16:22:25 +0000
@@ -1,6 +1,6 @@
 /* Copyright (c) 2011, Canonical Ltd. All rights reserved. */
 
-YUI().add('lp.buglisting_utils', function(Y) {
+YUI.add('lp.buglisting_utils', function(Y) {
     /**
      * A utility for configuring the display of bug listings.
      *