← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~wallyworld/launchpad/more-mochikit-fallout into lp:launchpad

 

The proposal to merge lp:~wallyworld/launchpad/more-mochikit-fallout into lp:launchpad has been updated.

Description changed to:

Fix last remaining (hopefully) fallout from removing mochikit.

1. Port more connect() calls found in TAL to use Y.on()
2. Fix a trim() call -> Y.Lang.trim()
3. Fix a selector in comment.js div#add-comment-form -> #add-comment-form

Tested locally.

As a side effect of the embedded js rework, a previously reported XSS bug was also fixed.

For more details, see:
https://code.launchpad.net/~wallyworld/launchpad/more-mochikit-fallout/+merge/88814
-- 
https://code.launchpad.net/~wallyworld/launchpad/more-mochikit-fallout/+merge/88814
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/more-mochikit-fallout into lp:launchpad.


References