launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #06119
[Merge] lp:~wgrant/launchpad/unpasswordify-tests into lp:launchpad
William Grant has proposed merging lp:~wgrant/launchpad/unpasswordify-tests into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~wgrant/launchpad/unpasswordify-tests/+merge/89031
With basic authentication now hardcoded to use a password of 'test', it is no longer useful for tests or the factory to create passwords on new people. This branch removes the factory's password arguments, and fixes tests to not try to use them.
--
https://code.launchpad.net/~wgrant/launchpad/unpasswordify-tests/+merge/89031
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/unpasswordify-tests into lp:launchpad.
=== modified file 'lib/lp/blueprints/browser/tests/test_views.py'
--- lib/lp/blueprints/browser/tests/test_views.py 2012-01-01 02:58:52 +0000
+++ lib/lp/blueprints/browser/tests/test_views.py 2012-01-18 13:30:57 +0000
@@ -59,7 +59,7 @@
collector = QueryCollector()
collector.register()
self.addCleanup(collector.unregister)
- viewer = self.factory.makePerson(password="test")
+ viewer = self.factory.makePerson()
browser = self.getUserBrowser(user=viewer)
url = canonical_url(target) + "/+assignments"
# Seed the cookie cache and any other cross-request state we may gain
=== modified file 'lib/lp/bugs/browser/tests/test_bugnomination.py'
--- lib/lp/bugs/browser/tests/test_bugnomination.py 2012-01-01 02:58:52 +0000
+++ lib/lp/bugs/browser/tests/test_bugnomination.py 2012-01-18 13:30:57 +0000
@@ -88,8 +88,7 @@
def test_bug_supervisor_nominate_distribution_does_not_error(self):
# A bug supervisor should not receive error notifications
# from the BugNominationView for a distro series.
- person = self.factory.makePerson(
- name='main-person-test', password='test')
+ person = self.factory.makePerson(name='main-person-test')
distro = self.factory.makeDistribution()
owner = distro.owner
self._makeBugSupervisorTeam(person, owner, distro)
@@ -108,8 +107,7 @@
def test_bug_supervisor_nominate_source_package_does_not_error(self):
# A bug supervisor should not receive error notifications
# from the BugNominationView for a source package distro series.
- person = self.factory.makePerson(
- name='main-person-test', password='test')
+ person = self.factory.makePerson(name='main-person-test')
distro = self.factory.makeDistribution()
owner = distro.owner
self._makeBugSupervisorTeam(person, owner, distro)
@@ -132,8 +130,7 @@
def test_bug_supervisor_nominate_product_does_not_error(self):
# A bug supervisor should not receive error notifications
# from the BugNominationView for a product series.
- person = self.factory.makePerson(
- name='main-person-test-product', password='test')
+ person = self.factory.makePerson(name='main-person-test-product')
product = self.factory.makeProduct()
owner = product.owner
self._makeBugSupervisorTeam(person, owner, product)
=== modified file 'lib/lp/bugs/browser/tests/test_bugtask.py'
--- lib/lp/bugs/browser/tests/test_bugtask.py 2012-01-16 17:20:45 +0000
+++ lib/lp/bugs/browser/tests/test_bugtask.py 2012-01-18 13:30:57 +0000
@@ -108,8 +108,8 @@
def test_rendered_query_counts_constant_with_team_memberships(self):
login(ADMIN_EMAIL)
task = self.factory.makeBugTask()
- person_no_teams = self.factory.makePerson(password='test')
- person_with_teams = self.factory.makePerson(password='test')
+ person_no_teams = self.factory.makePerson()
+ person_with_teams = self.factory.makePerson()
for _ in range(10):
self.factory.makeTeam(members=[person_with_teams])
# count with no teams
=== modified file 'lib/lp/bugs/stories/bug-release-management/xx-bug-release-management.txt'
--- lib/lp/bugs/stories/bug-release-management/xx-bug-release-management.txt 2012-01-15 10:25:39 +0000
+++ lib/lp/bugs/stories/bug-release-management/xx-bug-release-management.txt 2012-01-18 13:30:57 +0000
@@ -85,7 +85,7 @@
A bug can be nominated for a distribution release.
>>> login('foo.bar@xxxxxxxxxxxxx')
- >>> nominater = factory.makePerson(name='denominater', password='test')
+ >>> nominater = factory.makePerson(name='denominater')
>>> poseidon = factory.makeDistribution(name='poseidon',
... bug_supervisor=nominater)
>>> dsp = factory.makeDistributionSourcePackage(distribution=poseidon)
@@ -156,7 +156,7 @@
A bug can be nominated for a product series.
>>> login('foo.bar@xxxxxxxxxxxxx')
- >>> nominater = factory.makePerson(name='nominater', password='test')
+ >>> nominater = factory.makePerson(name='nominater')
>>> widget = factory.makeProduct(name='widget',
... official_malone = True,
... bug_supervisor=nominater)
=== modified file 'lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt'
--- lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt 2012-01-15 10:25:39 +0000
+++ lib/lp/bugs/stories/bug-tags/xx-official-bug-tags.txt 2012-01-18 13:30:57 +0000
@@ -58,7 +58,7 @@
>>> from lp.testing.sampledata import ADMIN_EMAIL
>>> from lp.testing import login, logout
>>> login(ADMIN_EMAIL)
- >>> supervisor = factory.makePerson(password='test')
+ >>> supervisor = factory.makePerson()
>>> youbuntu = factory.makeProduct(name='youbuntu',
... bug_supervisor=supervisor,
... official_malone=True)
=== modified file 'lib/lp/bugs/stories/bugtracker/xx-reschedule-all-watches.txt'
--- lib/lp/bugs/stories/bugtracker/xx-reschedule-all-watches.txt 2012-01-15 10:25:39 +0000
+++ lib/lp/bugs/stories/bugtracker/xx-reschedule-all-watches.txt 2012-01-18 13:30:57 +0000
@@ -42,7 +42,7 @@
>>> login(ADMIN_EMAIL)
>>> admin_user = getUtility(IPersonSet).getByEmail(ADMIN_EMAIL)
- >>> new_lp_developer = factory.makePerson(password='test')
+ >>> new_lp_developer = factory.makePerson()
>>> launchpad_developers = getUtility(
... ILaunchpadCelebrities).launchpad_developers
>>> dev_added = launchpad_developers.addMember(
=== modified file 'lib/lp/bugs/stories/bugwatches/xx-edit-bugwatch.txt'
--- lib/lp/bugs/stories/bugwatches/xx-edit-bugwatch.txt 2012-01-15 10:25:39 +0000
+++ lib/lp/bugs/stories/bugwatches/xx-edit-bugwatch.txt 2012-01-18 13:30:57 +0000
@@ -292,7 +292,7 @@
>>> login(ADMIN_EMAIL)
>>> admin_user = getUtility(IPersonSet).getByEmail(ADMIN_EMAIL)
- >>> new_lp_developer = factory.makePerson(password='test')
+ >>> new_lp_developer = factory.makePerson()
>>> launchpad_developers = getUtility(
... ILaunchpadCelebrities).launchpad_developers
>>> dev_added = launchpad_developers.addMember(
=== modified file 'lib/lp/code/adapters/tests/test_branch.py'
--- lib/lp/code/adapters/tests/test_branch.py 2012-01-01 02:58:52 +0000
+++ lib/lp/code/adapters/tests/test_branch.py 2012-01-18 13:30:57 +0000
@@ -45,8 +45,7 @@
def test_Modification(self):
"""When there are modifications, the delta reflects them."""
registrant = self.factory.makePerson(
- displayname='Baz Qux', email='baz.qux@xxxxxxxxxxx',
- password='test')
+ displayname='Baz Qux', email='baz.qux@xxxxxxxxxxx')
merge_proposal = self.factory.makeBranchMergeProposal(
registrant=registrant)
old_merge_proposal = BranchMergeProposalDelta.snapshot(merge_proposal)
=== modified file 'lib/lp/code/browser/tests/test_branch.py'
--- lib/lp/code/browser/tests/test_branch.py 2011-12-30 06:14:56 +0000
+++ lib/lp/code/browser/tests/test_branch.py 2012-01-18 13:30:57 +0000
@@ -120,8 +120,7 @@
def testHiddenBranchAsBranchOwner(self):
# A branch location with a defined private host is visible to the
# owner.
- owner = self.factory.makePerson(
- email="eric@xxxxxxxxxxx", password="test")
+ owner = self.factory.makePerson(email="eric@xxxxxxxxxxx")
branch = self.factory.makeAnyBranch(
branch_type=BranchType.MIRRORED,
owner=owner,
@@ -138,10 +137,8 @@
def testHiddenBranchAsOtherLoggedInUser(self):
# A branch location with a defined private host is hidden from other
# users.
- owner = self.factory.makePerson(
- email="eric@xxxxxxxxxxx", password="test")
- other = self.factory.makePerson(
- email="other@xxxxxxxxxxx", password="test")
+ owner = self.factory.makePerson(email="eric@xxxxxxxxxxx")
+ other = self.factory.makePerson(email="other@xxxxxxxxxxx")
branch = self.factory.makeAnyBranch(
branch_type=BranchType.MIRRORED,
owner=owner,
=== modified file 'lib/lp/code/browser/tests/test_branchlisting.py'
--- lib/lp/code/browser/tests/test_branchlisting.py 2012-01-04 19:34:47 +0000
+++ lib/lp/code/browser/tests/test_branchlisting.py 2012-01-18 13:30:57 +0000
@@ -640,8 +640,7 @@
private_team = self.factory.makeTeam(
name='shh', displayname='Shh', owner=owner,
visibility=PersonVisibility.PRIVATE)
- member = self.factory.makePerson(
- email='member@xxxxxxxxxxx', password='test')
+ member = self.factory.makePerson(email='member@xxxxxxxxxxx')
with person_logged_in(owner):
private_team.addMember(member, owner)
branch = self.factory.makeProductBranch(owner=private_team)
=== modified file 'lib/lp/code/browser/tests/test_sourcepackagerecipe.py'
--- lib/lp/code/browser/tests/test_sourcepackagerecipe.py 2012-01-06 08:24:33 +0000
+++ lib/lp/code/browser/tests/test_sourcepackagerecipe.py 2012-01-18 13:30:57 +0000
@@ -96,7 +96,7 @@
"""Provide useful defaults."""
super(TestCaseForRecipe, self).setUp()
self.chef = self.factory.makePerson(
- displayname='Master Chef', name='chef', password='test')
+ displayname='Master Chef', name='chef')
self.user = self.chef
self.ppa = self.factory.makeArchive(
displayname='Secret PPA', owner=self.chef, name='ppa')
@@ -605,7 +605,7 @@
def test_ppa_selector_not_shown_if_user_has_no_ppas(self):
# If the user creating a recipe has no existing PPAs, the selector
# isn't shown, but the field to enter a new PPA name is.
- self.user = self.factory.makePerson(password='test')
+ self.user = self.factory.makePerson()
branch = self.factory.makeAnyBranch()
with person_logged_in(self.user):
content = self.getMainContent(branch, '+new-recipe')
@@ -645,7 +645,7 @@
def test_create_new_ppa(self):
# If the user doesn't have any PPAs, a new once can be created.
- self.user = self.factory.makePerson(name='eric', password='test')
+ self.user = self.factory.makePerson(name='eric')
branch = self.factory.makeAnyBranch()
# A new recipe can be created from the branch page.
@@ -667,7 +667,7 @@
def test_create_new_ppa_duplicate(self):
# If a new PPA is being created, and the user already has a ppa of the
# name specifed an error is shown.
- self.user = self.factory.makePerson(name='eric', password='test')
+ self.user = self.factory.makePerson(name='eric')
# Make a PPA called 'ppa' using the default.
self.user.createPPA(name='foo')
branch = self.factory.makeAnyBranch()
@@ -688,7 +688,7 @@
def test_create_new_ppa_missing_name(self):
# If a new PPA is being created, and the user has not specified a
# name, an error is shown.
- self.user = self.factory.makePerson(name='eric', password='test')
+ self.user = self.factory.makePerson(name='eric')
branch = self.factory.makeAnyBranch()
# A new recipe can be created from the branch page.
@@ -705,7 +705,7 @@
def test_create_new_ppa_owned_by_recipe_owner(self):
# The new PPA that is created is owned by the recipe owner.
- self.user = self.factory.makePerson(name='eric', password='test')
+ self.user = self.factory.makePerson(name='eric')
team = self.factory.makeTeam(
name='vikings', members=[self.user],
subscription_policy=TeamSubscriptionPolicy.MODERATED)
@@ -1583,7 +1583,7 @@
"""Provide useful defaults."""
super(TestSourcePackageRecipeBuildView, self).setUp()
self.user = self.factory.makePerson(
- displayname='Owner', name='build-owner', password='test')
+ displayname='Owner', name='build-owner')
def makeBuild(self):
"""Make a build suitabe for testing."""
=== modified file 'lib/lp/code/browser/tests/test_sourcepackagerecipebuild.py'
--- lib/lp/code/browser/tests/test_sourcepackagerecipebuild.py 2012-01-01 02:58:52 +0000
+++ lib/lp/code/browser/tests/test_sourcepackagerecipebuild.py 2012-01-18 13:30:57 +0000
@@ -59,7 +59,7 @@
super(TestSourcePackageRecipeBuild, self).setUp()
self.admin = getUtility(IPersonSet).getByEmail(ADMIN_EMAIL)
self.chef = self.factory.makePerson(
- displayname='Master Chef', name='chef', password='test')
+ displayname='Master Chef', name='chef')
self.user = self.chef
self.ppa = self.factory.makeArchive(
displayname='Secret PPA', owner=self.chef, name='ppa')
=== modified file 'lib/lp/code/doc/branch-karma.txt'
--- lib/lp/code/doc/branch-karma.txt 2010-12-02 16:13:51 +0000
+++ lib/lp/code/doc/branch-karma.txt 2012-01-18 13:30:57 +0000
@@ -35,7 +35,7 @@
>>> login('test@xxxxxxxxxxxxx')
>>> fooix = factory.makeProduct(name='fooix')
- >>> eric = factory.makePerson(name='eric', password='test')
+ >>> eric = factory.makePerson(name='eric')
>>> branch = factory.makeProductBranch(owner=eric, product=fooix)
Karma added: action=branchcreated, product=fooix, person=eric
=== modified file 'lib/lp/code/stories/branches/package-branch-merge-proposals.txt'
--- lib/lp/code/stories/branches/package-branch-merge-proposals.txt 2009-09-17 03:12:08 +0000
+++ lib/lp/code/stories/branches/package-branch-merge-proposals.txt 2012-01-18 13:30:57 +0000
@@ -4,8 +4,7 @@
branches.
>>> login(ANONYMOUS)
- >>> eric = factory.makePerson(
- ... name="eric", password="test", email="eric@xxxxxxxxxxx")
+ >>> eric = factory.makePerson(name="eric", email="eric@xxxxxxxxxxx")
>>> b1 = factory.makePackageBranch(owner=eric)
>>> b2 = factory.makePackageBranch(
... owner=eric, sourcepackage=b1.sourcepackage)
=== modified file 'lib/lp/code/stories/branches/package-branch-merges-with-product-branches.txt'
--- lib/lp/code/stories/branches/package-branch-merges-with-product-branches.txt 2009-09-17 03:12:08 +0000
+++ lib/lp/code/stories/branches/package-branch-merges-with-product-branches.txt 2012-01-18 13:30:57 +0000
@@ -5,8 +5,7 @@
and vice versa.
>>> login(ANONYMOUS)
- >>> eric = factory.makePerson(
- ... name="eric", password="test", email="eric@xxxxxxxxxxx")
+ >>> eric = factory.makePerson(name="eric", email="eric@xxxxxxxxxxx")
>>> b1 = factory.makePackageBranch(owner=eric)
>>> b2 = factory.makeProductBranch(owner=eric)
>>> b1_url = canonical_url(b1)
=== modified file 'lib/lp/code/stories/branches/xx-branch-deletion.txt'
--- lib/lp/code/stories/branches/xx-branch-deletion.txt 2011-08-29 12:23:55 +0000
+++ lib/lp/code/stories/branches/xx-branch-deletion.txt 2012-01-18 13:30:57 +0000
@@ -7,8 +7,7 @@
>>> from lp.code.enums import BranchType
>>> login(ANONYMOUS)
- >>> alice = factory.makePerson(name="alice", password="test",
- ... email="alice@xxxxxxxxxxx")
+ >>> alice = factory.makePerson(name="alice", email="alice@xxxxxxxxxxx")
>>> product = factory.makeProduct(
... name='earthlynx', displayname="Earth Lynx", owner=alice)
>>> branch = factory.makeProductBranch(
=== modified file 'lib/lp/code/stories/branches/xx-branch-edit-privacy.txt'
--- lib/lp/code/stories/branches/xx-branch-edit-privacy.txt 2011-08-25 11:35:36 +0000
+++ lib/lp/code/stories/branches/xx-branch-edit-privacy.txt 2012-01-18 13:30:57 +0000
@@ -13,7 +13,7 @@
>>> login('admin@xxxxxxxxxxxxx')
>>> eric = factory.makePerson(
... name='eric', displayname='Eric the Viking',
- ... email='eric@xxxxxxxxxxx', password='test')
+ ... email='eric@xxxxxxxxxxx')
>>> fooix = factory.makeProduct(
... name='fooix', displayname='Fooix', owner=eric)
>>> trunk = factory.makeProductBranch(
=== modified file 'lib/lp/code/stories/branches/xx-branch-edit.txt'
--- lib/lp/code/stories/branches/xx-branch-edit.txt 2011-07-13 05:31:42 +0000
+++ lib/lp/code/stories/branches/xx-branch-edit.txt 2012-01-18 13:30:57 +0000
@@ -331,7 +331,7 @@
... name='official-owner', displayname='Jane Doe')
>>> branch = make_official_package_branch(factory, owner=owner)
>>> editor = factory.makePerson(
- ... name='editor', email='editor@xxxxxxxxxxx', password='test')
+ ... name='editor', email='editor@xxxxxxxxxxx')
>>> archive = branch.distroseries.distribution.main_archive
>>> spn = branch.sourcepackage.sourcepackagename
>>> from lp.soyuz.interfaces.archivepermission import (
=== modified file 'lib/lp/code/stories/branches/xx-branch-mirror-failures.txt'
--- lib/lp/code/stories/branches/xx-branch-mirror-failures.txt 2011-12-30 06:14:56 +0000
+++ lib/lp/code/stories/branches/xx-branch-mirror-failures.txt 2012-01-18 13:30:57 +0000
@@ -5,8 +5,7 @@
>>> from lp.testing import ANONYMOUS, login, logout
>>> login(ANONYMOUS)
- >>> eric = factory.makePerson(
- ... name='eric', email='eric@xxxxxxxxxxx', password='test')
+ >>> eric = factory.makePerson(name='eric', email='eric@xxxxxxxxxxx')
>>> from lp.code.enums import BranchType
>>> mirror_branch = factory.makeAnyBranch(
... branch_type=BranchType.MIRRORED, owner=eric)
=== modified file 'lib/lp/code/stories/branches/xx-branchmergeproposal-listings.txt'
--- lib/lp/code/stories/branches/xx-branchmergeproposal-listings.txt 2010-10-20 19:13:24 +0000
+++ lib/lp/code/stories/branches/xx-branchmergeproposal-listings.txt 2012-01-18 13:30:57 +0000
@@ -23,7 +23,7 @@
Make a single proposal for albert that is needing review by robert.
>>> albert = factory.makePerson(
- ... name='albert', email="albert@xxxxxxxxxxx", password="test")
+ ... name='albert', email="albert@xxxxxxxxxxx")
>>> robert = factory.makePerson(name='robert')
>>> branch = factory.makeProductBranch(
... owner=albert, product=fooix, name='review')
=== modified file 'lib/lp/code/stories/branches/xx-claiming-team-code-reviews.txt'
--- lib/lp/code/stories/branches/xx-claiming-team-code-reviews.txt 2010-02-18 00:39:27 +0000
+++ lib/lp/code/stories/branches/xx-claiming-team-code-reviews.txt 2012-01-18 13:30:57 +0000
@@ -7,7 +7,7 @@
>>> # Logging in as an admin helps with setting things up.
>>> login('admin@xxxxxxxxxxxxx')
>>> eric = factory.makePerson(
- ... name="eric", email="eric@xxxxxxxxxxx", password="test",
+ ... name="eric", email="eric@xxxxxxxxxxx",
... displayname="Eric the Viking")
>>> vikings = factory.makeTeam(
... owner=eric, displayname="Vikings", name="vikings")
=== modified file 'lib/lp/code/stories/branches/xx-code-review-comments.txt'
--- lib/lp/code/stories/branches/xx-code-review-comments.txt 2011-11-29 20:51:38 +0000
+++ lib/lp/code/stories/branches/xx-code-review-comments.txt 2012-01-18 13:30:57 +0000
@@ -6,7 +6,7 @@
>>> # We need to be admin to add a landing target to a random branch
>>> login('foo.bar@xxxxxxxxxxxxx')
>>> eric = factory.makePerson(
- ... name="eric", email="eric@xxxxxxxxxxx", password="test",
+ ... name="eric", email="eric@xxxxxxxxxxx",
... displayname="Eric the Viking")
>>> merge_proposal = factory.makeBranchMergeProposal(reviewer=eric)
>>> merge_proposal_url = canonical_url(merge_proposal)
=== modified file 'lib/lp/code/stories/branches/xx-junk-branches.txt'
--- lib/lp/code/stories/branches/xx-junk-branches.txt 2011-10-03 15:35:14 +0000
+++ lib/lp/code/stories/branches/xx-junk-branches.txt 2012-01-18 13:30:57 +0000
@@ -4,8 +4,7 @@
Create a person and team.
>>> login(ANONYMOUS)
- >>> eric = factory.makePerson(
- ... name='eric', password='test', email='eric@xxxxxxxxxxx')
+ >>> eric = factory.makePerson(name='eric', email='eric@xxxxxxxxxxx')
>>> vikings = factory.makeTeam(name='vikings', owner=eric)
>>> logout()
=== modified file 'lib/lp/code/stories/branches/xx-person-branches.txt'
--- lib/lp/code/stories/branches/xx-person-branches.txt 2010-11-08 10:42:09 +0000
+++ lib/lp/code/stories/branches/xx-person-branches.txt 2012-01-18 13:30:57 +0000
@@ -102,7 +102,7 @@
>>> login(ANONYMOUS)
>>> eric = factory.makePerson(
- ... name="eric", password="test", email="eric@xxxxxxxxxxx",
+ ... name="eric", email="eric@xxxxxxxxxxx",
... displayname="Eric the Viking")
>>> b1 = factory.makeAnyBranch(owner=eric)
>>> logout()
=== modified file 'lib/lp/code/stories/branches/xx-person-portlet-teambranches.txt'
--- lib/lp/code/stories/branches/xx-person-portlet-teambranches.txt 2010-12-22 14:50:08 +0000
+++ lib/lp/code/stories/branches/xx-person-portlet-teambranches.txt 2012-01-18 13:30:57 +0000
@@ -8,7 +8,7 @@
>>> login(ANONYMOUS)
>>> eric = factory.makePerson(
- ... name="eric", password="test", email="eric@xxxxxxxxxxx",
+ ... name="eric", email="eric@xxxxxxxxxxx",
... displayname="Eric the Viking")
>>> vikings = factory.makeTeam(name="vikings", owner=eric)
>>> # Also give vikings a cool icon.
=== modified file 'lib/lp/code/stories/branches/xx-reviewing.txt'
--- lib/lp/code/stories/branches/xx-reviewing.txt 2010-10-26 03:06:30 +0000
+++ lib/lp/code/stories/branches/xx-reviewing.txt 2012-01-18 13:30:57 +0000
@@ -5,8 +5,7 @@
team review the proposal on behalf of the team.
>>> login(ANONYMOUS)
- >>> eric = factory.makePerson(
- ... name='eric', email='eric@xxxxxxxxxxx', password='test')
+ >>> eric = factory.makePerson(name='eric', email='eric@xxxxxxxxxxx')
>>> vikings = factory.makeTeam(owner=eric, name='vikings')
>>> from lp.code.tests.helpers import (
... make_merge_proposal_without_reviewers)
=== modified file 'lib/lp/code/stories/branches/xx-subscribing-branches.txt'
--- lib/lp/code/stories/branches/xx-subscribing-branches.txt 2011-12-13 17:45:31 +0000
+++ lib/lp/code/stories/branches/xx-subscribing-branches.txt 2012-01-18 13:30:57 +0000
@@ -270,8 +270,7 @@
>>> private_team = factory.makeTeam(
... name='shh', displayname='Shh',
... visibility=PersonVisibility.PRIVATE)
- >>> member = factory.makePerson(
- ... email='shh@xxxxxxxxxxx', password='test')
+ >>> member = factory.makePerson(email='shh@xxxxxxxxxxx')
>>> ignored = private_team.addMember(member, private_team.teamowner)
>>> owner = factory.makePerson(name='branch-owner')
>>> branch = factory.makeAnyBranch(owner=owner)
=== modified file 'lib/lp/code/stories/branches/xx-upgrading-branches.txt'
--- lib/lp/code/stories/branches/xx-upgrading-branches.txt 2010-01-29 11:56:38 +0000
+++ lib/lp/code/stories/branches/xx-upgrading-branches.txt 2012-01-18 13:30:57 +0000
@@ -14,8 +14,7 @@
>>> from lp.code.bzr import BranchFormat, RepositoryFormat
>>> login('foo.bar@xxxxxxxxxxxxx')
- >>> domino = factory.makePerson(
- ... name='domino', email="fats@xxxxxxxxxx", password="test")
+ >>> domino = factory.makePerson(name='domino', email="fats@xxxxxxxxxx")
>>> twist = factory.makeAnyBranch(
... branch_format=BranchFormat.BZR_BRANCH_6,
... repository_format=RepositoryFormat.BZR_CHK_2A,
=== modified file 'lib/lp/code/stories/codeimport/xx-edit-codeimport.txt'
--- lib/lp/code/stories/codeimport/xx-edit-codeimport.txt 2011-12-24 17:49:30 +0000
+++ lib/lp/code/stories/codeimport/xx-edit-codeimport.txt 2012-01-18 13:30:57 +0000
@@ -11,7 +11,7 @@
>>> from lp.services.webapp import canonical_url
>>> login(ANONYMOUS)
- >>> registrant = factory.makePerson(password='test')
+ >>> registrant = factory.makePerson()
>>> svn_import = factory.makeProductCodeImport(
... svn_branch_url='svn://svn.example.com/fooix/trunk',
... registrant=registrant)
=== modified file 'lib/lp/code/tests/helpers.py'
--- lib/lp/code/tests/helpers.py 2011-12-30 06:14:56 +0000
+++ lib/lp/code/tests/helpers.py 2012-01-18 13:30:57 +0000
@@ -92,8 +92,7 @@
:return: a dict of objects to put into local scope.
"""
eric = factory.makePerson(
- name='eric', displayname='Eric the Viking',
- email='eric@xxxxxxxxxxx', password='test')
+ name='eric', displayname='Eric the Viking', email='eric@xxxxxxxxxxx')
fooix = factory.makeProduct(
name='fooix', displayname='Fooix', owner=eric)
trunk = factory.makeProductBranch(
@@ -101,8 +100,7 @@
removeSecurityProxy(fooix.development_focus).branch = trunk
# Development is done by Fred.
fred = factory.makePerson(
- name='fred', displayname='Fred Flintstone',
- email='fred@xxxxxxxxxxx', password='test')
+ name='fred', displayname='Fred Flintstone', email='fred@xxxxxxxxxxx')
feature = factory.makeProductBranch(
owner=fred, product=fooix, name='feature')
proposed = factory.makeProductBranch(
@@ -209,8 +207,7 @@
twisted, zope, bzr, python
"""
albert, bob, charlie = [
- factory.makePerson(
- name=name, email=("%s@xxxxxxxxxxxxxxxx" % name), password="test")
+ factory.makePerson(name=name, email=("%s@xxxxxxxxxxxxxxxx" % name))
for name in ('albert', 'bob', 'charlie')]
mint_team = factory.makeTeam(owner=albert, name="mint-team")
mint_team.addMember(bob, albert)
=== modified file 'lib/lp/code/windmill/tests/test_branch_status.py'
--- lib/lp/code/windmill/tests/test_branch_status.py 2011-12-22 09:05:46 +0000
+++ lib/lp/code/windmill/tests/test_branch_status.py 2012-01-18 13:30:57 +0000
@@ -25,7 +25,7 @@
def test_inline_branch_status_setting(self):
"""Set the status of a branch."""
eric = self.factory.makePerson(
- name="eric", displayname="Eric the Viking", password="test",
+ name="eric", displayname="Eric the Viking",
email="eric@xxxxxxxxxxx")
branch = self.factory.makeBranch(owner=eric)
transaction.commit()
=== modified file 'lib/lp/code/windmill/tests/test_branchmergeproposal_commitmessage.py'
--- lib/lp/code/windmill/tests/test_branchmergeproposal_commitmessage.py 2011-03-29 07:10:40 +0000
+++ lib/lp/code/windmill/tests/test_branchmergeproposal_commitmessage.py 2012-01-18 13:30:57 +0000
@@ -37,7 +37,7 @@
def test_set_commit_message(self):
"""Test the commit message multiline editor."""
eric = self.factory.makePerson(
- name="eric", displayname="Eric the Viking", password="test",
+ name="eric", displayname="Eric the Viking",
email="eric@xxxxxxxxxxx")
bmp = self.factory.makeBranchMergeProposal(registrant=eric)
transaction.commit()
@@ -72,8 +72,7 @@
def test_inline_queue_status_setting(self):
"""Test setting the queue_status with the ChoiceWidget."""
mike = self.factory.makePerson(
- name="mike", displayname="Mike Tyson", password="test",
- email="mike@xxxxxxxxxxx")
+ name="mike", displayname="Mike Tyson", email="mike@xxxxxxxxxxx")
branch = self.factory.makeBranch(owner=mike)
second_branch = self.factory.makeBranch(product=branch.product)
self.factory.makeRevisionsForBranch(second_branch)
=== modified file 'lib/lp/code/windmill/tests/test_recipe_index.py'
--- lib/lp/code/windmill/tests/test_recipe_index.py 2011-12-19 23:38:16 +0000
+++ lib/lp/code/windmill/tests/test_recipe_index.py 2012-01-18 13:30:57 +0000
@@ -23,7 +23,7 @@
def test_inline_recipe_daily_build(self):
eric = self.factory.makePerson(
- name="eric", displayname="Eric the Viking", password="test",
+ name="eric", displayname="Eric the Viking",
email="eric@xxxxxxxxxxx")
recipe = self.factory.makeSourcePackageRecipe(owner=eric)
transaction.commit()
@@ -47,7 +47,7 @@
def test_inline_recipe_text_errors(self):
# XXX: do we really want to error check here?
eric = self.factory.makePerson(
- name="eric", displayname="Eric the Viking", password="test",
+ name="eric", displayname="Eric the Viking",
email="eric@xxxxxxxxxxx")
recipe = self.factory.makeSourcePackageRecipe(owner=eric)
recipe_text = recipe.recipe_text + 'merge WTF?'
=== modified file 'lib/lp/code/windmill/tests/test_recipe_inline_distroseries_edit.py'
--- lib/lp/code/windmill/tests/test_recipe_inline_distroseries_edit.py 2011-05-27 21:12:25 +0000
+++ lib/lp/code/windmill/tests/test_recipe_inline_distroseries_edit.py 2012-01-18 13:30:57 +0000
@@ -30,8 +30,7 @@
"""Test that inline editing of distroseries works."""
chef = self.factory.makePerson(
- displayname='Master Chef', name='chef', password='test',
- email="chef@xxxxxxxxxxx")
+ displayname='Master Chef', name='chef', email="chef@xxxxxxxxxxx")
recipe = self.factory.makeSourcePackageRecipe(owner=chef)
transaction.commit()
=== modified file 'lib/lp/code/windmill/tests/test_recipe_request_build.py'
--- lib/lp/code/windmill/tests/test_recipe_request_build.py 2011-12-19 23:38:16 +0000
+++ lib/lp/code/windmill/tests/test_recipe_request_build.py 2012-01-18 13:30:57 +0000
@@ -33,8 +33,7 @@
def setUp(self):
super(TestRecipeBuild, self).setUp()
self.chef = self.factory.makePerson(
- displayname='Master Chef', name='chef', password='test',
- email="chef@xxxxxxxxxxx")
+ displayname='Master Chef', name='chef', email="chef@xxxxxxxxxxx")
self.user = self.chef
self.ppa = self.factory.makeArchive(
displayname='Secret PPA', owner=self.chef, name='ppa')
=== modified file 'lib/lp/registry/browser/tests/person-views.txt'
--- lib/lp/registry/browser/tests/person-views.txt 2011-12-22 05:09:10 +0000
+++ lib/lp/registry/browser/tests/person-views.txt 2012-01-18 13:30:57 +0000
@@ -314,7 +314,7 @@
when the user does not have any assigned bug or specs that are not in
progress.
- >>> user = factory.makePerson(name='ken', password='test')
+ >>> user = factory.makePerson(name='ken')
>>> view = create_initialized_view(user, name='+portlet-currentfocus')
>>> view.has_assigned_bugs_or_specs_in_progress
False
=== modified file 'lib/lp/registry/browser/tests/test_milestone.py'
--- lib/lp/registry/browser/tests/test_milestone.py 2012-01-11 09:46:21 +0000
+++ lib/lp/registry/browser/tests/test_milestone.py 2012-01-18 13:30:57 +0000
@@ -322,7 +322,7 @@
# shortcuts avoiding queries : test the worst case.
subscribed_team = self.factory.makeTeam(
subscription_policy=TeamSubscriptionPolicy.MODERATED)
- viewer = self.factory.makePerson(password="test")
+ viewer = self.factory.makePerson()
with person_logged_in(subscribed_team.teamowner):
subscribed_team.addMember(viewer, subscribed_team.teamowner)
bug1.subscribe(subscribed_team, product.owner)
=== modified file 'lib/lp/registry/stories/distroseries/distroseries-admin.txt'
--- lib/lp/registry/stories/distroseries/distroseries-admin.txt 2012-01-15 10:43:27 +0000
+++ lib/lp/registry/stories/distroseries/distroseries-admin.txt 2012-01-18 13:30:57 +0000
@@ -50,7 +50,7 @@
Registry experts do not have access to the 'Change details' link.
>>> email = "expert@xxxxxxxxxxx"
- >>> registry= factory.makeRegistryExpert(email=email, password="test")
+ >>> registry= factory.makeRegistryExpert(email=email)
>>> logout()
>>> registry_browser = setupBrowser(
... auth='Basic %s:test' % email)
=== modified file 'lib/lp/registry/stories/location/personlocation-edit.txt'
--- lib/lp/registry/stories/location/personlocation-edit.txt 2010-09-21 03:31:25 +0000
+++ lib/lp/registry/stories/location/personlocation-edit.txt 2012-01-18 13:30:57 +0000
@@ -7,7 +7,7 @@
>>> login('test@xxxxxxxxxxxxx')
>>> zzz = factory.makePerson(
... name='zzz', time_zone='Africa/Maseru', email='zzz@xxxxxxx',
- ... latitude=None, longitude=None, password='test')
+ ... latitude=None, longitude=None)
>>> logout()
A user cannot set another user's location.
=== modified file 'lib/lp/registry/stories/person/xx-admin-person-review.txt'
--- lib/lp/registry/stories/person/xx-admin-person-review.txt 2012-01-15 10:43:27 +0000
+++ lib/lp/registry/stories/person/xx-admin-person-review.txt 2012-01-18 13:30:57 +0000
@@ -97,7 +97,7 @@
Registry experts can see the +review page, minus the displayname.
>>> email = "expert@xxxxxxxxxxx"
- >>> expert = factory.makeRegistryExpert(email=email, password="test")
+ >>> expert = factory.makeRegistryExpert(email=email)
>>> expert_browser = setupBrowser(auth='Basic %s:test' % email)
>>> logout()
>>> expert_browser.open('http://launchpad.dev/~no-priv/+review')
=== modified file 'lib/lp/registry/stories/person/xx-person-edit.txt'
--- lib/lp/registry/stories/person/xx-person-edit.txt 2011-09-06 01:21:29 +0000
+++ lib/lp/registry/stories/person/xx-person-edit.txt 2012-01-18 13:30:57 +0000
@@ -7,8 +7,7 @@
>>> from lp.testing.sampledata import ADMIN_EMAIL
>>> login(ADMIN_EMAIL)
>>> user = factory.makePerson(name='ray', displayname='Ray Ray',
- ... email='ray@xxxxxxxxxxx',
- ... password='test')
+ ... email='ray@xxxxxxxxxxx')
>>> logout()
>>> browser.addHeader('Authorization', 'Basic ray@xxxxxxxxxxx:test')
>>> browser.open('http://launchpad.dev/~ray')
=== modified file 'lib/lp/registry/stories/person/xx-person-subscriptions.txt'
--- lib/lp/registry/stories/person/xx-person-subscriptions.txt 2012-01-15 10:25:39 +0000
+++ lib/lp/registry/stories/person/xx-person-subscriptions.txt 2012-01-18 13:30:57 +0000
@@ -29,7 +29,7 @@
>>> affluenza = factory.makeProduct(name='affluenza')
>>> bugB = factory.makeBug(product=affluenza,
... title='A terrible affliction')
- >>> subscriber = factory.makePerson(name='webster', password='test')
+ >>> subscriber = factory.makePerson(name='webster')
>>> subscriptionA = bugA.subscribe(subscriber, subscriber)
>>> subscriptionB = bugB.subscribe(subscriber, subscriber)
>>> logout()
@@ -259,8 +259,7 @@
>>> from lp.testing import celebrity_logged_in, person_logged_in
>>> with celebrity_logged_in("admin"):
- ... nigel = factory.makePerson(
- ... name="nigel", displayname="Nigel", password='test')
+ ... nigel = factory.makePerson(name="nigel", displayname="Nigel")
>>> with person_logged_in(nigel):
... nigel_subscription = scofflaw.addBugSubscription(nigel, nigel)
... nigel_browser = setupBrowser(
=== modified file 'lib/lp/registry/stories/product/xx-product-development-focus.txt'
--- lib/lp/registry/stories/product/xx-product-development-focus.txt 2011-08-29 07:55:48 +0000
+++ lib/lp/registry/stories/product/xx-product-development-focus.txt 2012-01-18 13:30:57 +0000
@@ -11,10 +11,8 @@
>>> from lp.testing import login, logout
>>> login('admin@xxxxxxxxxxxxx')
- >>> eric = factory.makePerson(
- ... name='eric', email='eric@xxxxxxxxxxx', password='test')
- >>> fooix = factory.makeProduct(
- ... name='fooix', owner=eric)
+ >>> eric = factory.makePerson(name='eric', email='eric@xxxxxxxxxxx')
+ >>> fooix = factory.makeProduct(name='fooix', owner=eric)
>>> branch = factory.makeBranch(owner=eric, product=fooix, name='trunk')
>>> # Make revisions for the branch so it has a codebrowse link.
>>> factory.makeRevisionsForBranch(branch)
=== modified file 'lib/lp/registry/stories/product/xx-product-edit.txt'
--- lib/lp/registry/stories/product/xx-product-edit.txt 2011-05-27 19:53:20 +0000
+++ lib/lp/registry/stories/product/xx-product-edit.txt 2012-01-18 13:30:57 +0000
@@ -313,7 +313,7 @@
>>> from lp.app.interfaces.launchpad import ILaunchpadCelebrities
>>> registry_member = factory.makePerson(
- ... name='reggie', email='reggie@xxxxxxxxxxx', password='test')
+ ... name='reggie', email='reggie@xxxxxxxxxxx')
>>> celebs = getUtility(ILaunchpadCelebrities)
>>> registry = celebs.registry_experts
>>> ignored = registry.addMember(registry_member, registry.teamowner)
=== modified file 'lib/lp/registry/stories/product/xx-productset.txt'
--- lib/lp/registry/stories/product/xx-productset.txt 2011-05-27 19:53:20 +0000
+++ lib/lp/registry/stories/product/xx-productset.txt 2012-01-18 13:30:57 +0000
@@ -20,7 +20,7 @@
>>> from zope.component import getUtility
>>> from lp.app.interfaces.launchpad import ILaunchpadCelebrities
>>> registry_member = factory.makePerson(
- ... name='reggie', email='reggie@xxxxxxxxxxx', password='test')
+ ... name='reggie', email='reggie@xxxxxxxxxxx')
>>> celebs = getUtility(ILaunchpadCelebrities)
>>> registry = celebs.registry_experts
>>> ignored = registry.addMember(registry_member, registry.teamowner)
=== modified file 'lib/lp/registry/stories/project/xx-project-edit.txt'
--- lib/lp/registry/stories/project/xx-project-edit.txt 2012-01-15 10:43:27 +0000
+++ lib/lp/registry/stories/project/xx-project-edit.txt 2012-01-18 13:30:57 +0000
@@ -120,8 +120,7 @@
Registry experts are not allowed access to the +edit page.
>>> email = "expert@xxxxxxxxxxx"
- >>> registry_expert= factory.makeRegistryExpert(email=email,
- ... password="test")
+ >>> registry_expert= factory.makeRegistryExpert(email=email)
>>> logout()
>>> expert_browser = setupBrowser(auth='Basic %s:test' % email)
=== modified file 'lib/lp/registry/stories/team/xx-adminteammerge.txt'
--- lib/lp/registry/stories/team/xx-adminteammerge.txt 2011-04-09 01:23:00 +0000
+++ lib/lp/registry/stories/team/xx-adminteammerge.txt 2012-01-18 13:30:57 +0000
@@ -8,8 +8,7 @@
>>> from zope.component import getUtility
>>> from lp.registry.interfaces.person import IPersonSet
>>> login('foo.bar@xxxxxxxxxxxxx')
- >>> registry_expert = factory.makePerson(
- ... email='reg@xxxxxxxxxxx', password='test')
+ >>> registry_expert = factory.makePerson(email='reg@xxxxxxxxxxx')
>>> new_team = factory.makeTeam(
... name="new-team", email="new_team@xxxxxxxxxxx")
>>> registry_experts = getUtility(IPersonSet).getByName('registry')
=== modified file 'lib/lp/services/features/browser/tests/test_feature_editor.py'
--- lib/lp/services/features/browser/tests/test_feature_editor.py 2012-01-01 02:58:52 +0000
+++ lib/lp/services/features/browser/tests/test_feature_editor.py 2012-01-18 13:30:57 +0000
@@ -43,14 +43,11 @@
:param teams: List of teams to add the new user to.
"""
- # XXX MartinPool 2010-09-23 bug=646563: To make a UserBrowser, you
- # must know the password; we can't get the password for an existing
- # user so we have to make a new one.
- self.user = self.factory.makePerson(password='test')
+ self.user = self.factory.makePerson()
for team in teams:
with person_logged_in(team.teamowner):
team.addMember(self.user, reviewer=team.teamowner)
- return self.getUserBrowser(url=None, user=self.user, password='test')
+ return self.getUserBrowser(url=None, user=self.user)
def getUserBrowserAsAdmin(self):
"""Make a new TestBrowser logged in as an admin user."""
=== modified file 'lib/lp/services/features/browser/tests/test_feature_info.py'
--- lib/lp/services/features/browser/tests/test_feature_info.py 2012-01-01 02:58:52 +0000
+++ lib/lp/services/features/browser/tests/test_feature_info.py 2012-01-18 13:30:57 +0000
@@ -49,14 +49,11 @@
def getUserBrowserAsTeamMember(self, teams):
"""Make a TestBrowser authenticated as a team member."""
- # XXX Martin Pool 2010-09-23 bug=646563: To make a UserBrowser, you
- # must know the password; we can't get the password for an existing
- # user so we have to make a new one.
- user = self.factory.makePerson(password='test')
+ user = self.factory.makePerson()
for team in teams:
with person_logged_in(team.teamowner):
team.addMember(user, reviewer=team.teamowner)
- return self.getUserBrowser(url=None, user=user, password='test')
+ return self.getUserBrowser(url=None, user=user)
def test_feature_documentation_displayed(self):
"""The feature flag documentation is displayed on the page."""
=== modified file 'lib/lp/soyuz/browser/tests/test_archive_packages.py'
--- lib/lp/soyuz/browser/tests/test_archive_packages.py 2012-01-10 21:49:12 +0000
+++ lib/lp/soyuz/browser/tests/test_archive_packages.py 2012-01-18 13:30:57 +0000
@@ -203,7 +203,7 @@
collector.register()
self.addCleanup(collector.unregister)
ppa = self.factory.makeArchive()
- viewer = self.factory.makePerson(password="test")
+ viewer = self.factory.makePerson()
browser = self.getUserBrowser(user=viewer)
with person_logged_in(viewer):
# The baseline has one package, because otherwise the
@@ -225,7 +225,7 @@
# gathered metrics.
login(ADMIN_EMAIL)
ppa = self.factory.makeArchive()
- viewer = self.factory.makePerson(password="test")
+ viewer = self.factory.makePerson()
browser = self.getUserBrowser(user=viewer)
with person_logged_in(viewer):
for i in range(2):
@@ -244,7 +244,7 @@
collector.register()
self.addCleanup(collector.unregister)
ppa = self.factory.makeArchive()
- viewer = self.factory.makePerson(password="test")
+ viewer = self.factory.makePerson()
browser = self.getUserBrowser(user=viewer)
with person_logged_in(viewer):
# The baseline has one package, because otherwise the
@@ -261,7 +261,7 @@
# gathered metrics.
login(ADMIN_EMAIL)
ppa = self.factory.makeArchive()
- viewer = self.factory.makePerson(password="test")
+ viewer = self.factory.makePerson()
browser = self.getUserBrowser(user=viewer)
with person_logged_in(viewer):
for i in range(3):
=== modified file 'lib/lp/soyuz/doc/archiveauthtoken.txt'
--- lib/lp/soyuz/doc/archiveauthtoken.txt 2011-12-08 20:24:09 +0000
+++ lib/lp/soyuz/doc/archiveauthtoken.txt 2012-01-18 13:30:57 +0000
@@ -25,7 +25,7 @@
>>> login("admin@xxxxxxxxxxxxx")
>>> bradsmith = factory.makePerson(
- ... name="bradsmith", displayname="Brad Smith", password="test",
+ ... name="bradsmith", displayname="Brad Smith",
... email="brad@xxxxxxxxxxx")
>>> teambrad = factory.makeTeam(
... owner=bradsmith, displayname="Team Brad", name='teambrad')
=== modified file 'lib/lp/soyuz/doc/archivesubscriber.txt'
--- lib/lp/soyuz/doc/archivesubscriber.txt 2011-12-30 06:14:56 +0000
+++ lib/lp/soyuz/doc/archivesubscriber.txt 2012-01-18 13:30:57 +0000
@@ -14,15 +14,12 @@
>>> login('foo.bar@xxxxxxxxxxxxx')
>>> joesmith = factory.makePerson(name="joesmith",
... displayname="Joe Smith",
- ... password="test",
... email="joe@xxxxxxxxxxx")
>>> johnsmith = factory.makePerson(name="johnsmith",
... displayname="John Smith",
- ... password="test",
... email="john@xxxxxxxxxxx")
>>> fredsmith = factory.makePerson(name="fredsmith",
... displayname="Fred Smith",
- ... password="test",
... email="fred@xxxxxxxxxxx")
>>> from lp.registry.interfaces.person import IPersonSet
>>> cprov = getUtility(IPersonSet).getByName("cprov")
@@ -489,7 +486,6 @@
>>> login("mark@xxxxxxxxxxx")
>>> harrysmith = factory.makePerson(name="harrysmith",
... displayname="Harry Smith",
- ... password="test",
... email="harry@xxxxxxxxxxx")
>>> subscription = mark_private_ppa.newSubscription(
... harrysmith, mark, description=u"subscription for joesmith")
=== modified file 'lib/lp/soyuz/stories/ppa/xx-private-ppa-subscription-stories.txt'
--- lib/lp/soyuz/stories/ppa/xx-private-ppa-subscription-stories.txt 2012-01-15 11:06:57 +0000
+++ lib/lp/soyuz/stories/ppa/xx-private-ppa-subscription-stories.txt 2012-01-18 13:30:57 +0000
@@ -51,8 +51,8 @@
and a client of Celso's who has a launchpad name of 'joesmith'
>>> login('foo.bar@xxxxxxxxxxxxx')
- >>> client = factory.makePerson(name="joesmith", displayname="Joe Smith",
- ... password="test", email="joe@xxxxxxxxxxx")
+ >>> client = factory.makePerson(
+ ... name="joesmith", displayname="Joe Smith", email="joe@xxxxxxxxxxx")
>>> logout()
When Celso fills in the form with 'joesmith' as the subscriber, a blank
=== modified file 'lib/lp/soyuz/stories/ppa/xx-private-ppa-subscriptions.txt'
--- lib/lp/soyuz/stories/ppa/xx-private-ppa-subscriptions.txt 2012-01-15 11:06:57 +0000
+++ lib/lp/soyuz/stories/ppa/xx-private-ppa-subscriptions.txt 2012-01-18 13:30:57 +0000
@@ -72,12 +72,13 @@
Create two new users that can be subscribed to archives, and a team:
>>> login('foo.bar@xxxxxxxxxxxxx')
- >>> joesmith = factory.makePerson(name="joesmith", displayname="Joe Smith",
- ... password="test", email="joe@xxxxxxxxxxx")
+ >>> joesmith = factory.makePerson(
+ ... name="joesmith", displayname="Joe Smith", email="joe@xxxxxxxxxxx")
>>> teamjoe = factory.makeTeam(
... owner=joesmith, displayname="Team Joe", name='teamjoe')
- >>> bradsmith = factory.makePerson(name="bradsmith", displayname="Brad Smith",
- ... password="test", email="brad@xxxxxxxxxxx")
+ >>> bradsmith = factory.makePerson(
+ ... name="bradsmith", displayname="Brad Smith",
+ ... email="brad@xxxxxxxxxxx")
>>> logout()
People and teams can be subscribed by entering their details into the
=== modified file 'lib/lp/soyuz/windmill/tests/test_archivesubscribersindex.py'
--- lib/lp/soyuz/windmill/tests/test_archivesubscribersindex.py 2011-03-29 05:59:29 +0000
+++ lib/lp/soyuz/windmill/tests/test_archivesubscribersindex.py 2012-01-18 13:30:57 +0000
@@ -41,7 +41,7 @@
super(TestArchiveSubscribersIndex, self).setUp()
user = self.factory.makePerson(
- name='joe-bloggs', email='joe@xxxxxxxxxxx', password='joe',
+ name='joe-bloggs', email='joe@xxxxxxxxxxx',
displayname='Joe Bloggs')
ubuntu = getUtility(IDistributionSet)['ubuntu']
self.ppa = self.factory.makeArchive(
@@ -54,7 +54,7 @@
transaction.commit()
self.lpuser = LaunchpadUser(
- 'Joe Bloggs', 'joe@xxxxxxxxxxx', 'joe')
+ 'Joe Bloggs', 'joe@xxxxxxxxxxx', 'test')
def test_add_subscriber(self):
"""Test adding a private PPA subscriber.."""
=== modified file 'lib/lp/testing/__init__.py'
--- lib/lp/testing/__init__.py 2011-12-30 06:14:56 +0000
+++ lib/lp/testing/__init__.py 2012-01-18 13:30:57 +0000
@@ -710,19 +710,17 @@
# messages.
trace._bzr_logger = logging.getLogger('bzr')
- def getUserBrowser(self, url=None, user=None, password='test'):
+ def getUserBrowser(self, url=None, user=None):
"""Return a Browser logged in as a fresh user, maybe opened at `url`.
:param user: The user to open a browser for.
- :param password: The password to use. (This cannot be determined
- because it's stored as a hash.)
"""
# Do the import here to avoid issues with import cycles.
from lp.testing.pages import setupBrowserForUser
login(ANONYMOUS)
if user is None:
- user = self.factory.makePerson(password=password)
- browser = setupBrowserForUser(user, password)
+ user = self.factory.makePerson()
+ browser = setupBrowserForUser(user)
if url is not None:
browser.open(url)
return browser
@@ -835,7 +833,7 @@
def setUp(self):
"""Provide useful defaults."""
super(BrowserTestCase, self).setUp()
- self.user = self.factory.makePerson(password='test')
+ self.user = self.factory.makePerson()
def getViewBrowser(self, context, view_name=None, no_login=False,
rootsite=None, user=None):
=== modified file 'lib/lp/testing/factory.py'
--- lib/lp/testing/factory.py 2012-01-17 23:55:44 +0000
+++ lib/lp/testing/factory.py 2012-01-18 13:30:57 +0000
@@ -528,14 +528,13 @@
return person
@with_celebrity_logged_in('admin')
- def makeAdministrator(self, name=None, email=None, password=None):
+ def makeAdministrator(self, name=None, email=None):
user = self.makePerson(name=name, email=email)
administrators = getUtility(ILaunchpadCelebrities).admin
administrators.addMember(user, administrators.teamowner)
return user
- def makeRegistryExpert(self, name=None, email='expert@xxxxxxxxxxx',
- password=None):
+ def makeRegistryExpert(self, name=None, email='expert@xxxxxxxxxxx'):
from lp.testing.sampledata import ADMIN_EMAIL
login(ADMIN_EMAIL)
user = self.makePerson(name=name, email=email)
@@ -597,16 +596,14 @@
can_encrypt=False)
def makePerson(
- self, email=None, name=None, password=None,
+ self, email=None, name=None, displayname=None, account_status=None,
email_address_status=None, hide_email_addresses=False,
- displayname=None, time_zone=None, latitude=None, longitude=None,
- selfgenerated_bugnotifications=False, member_of=(),
- homepage_content=None, account_status=None):
+ time_zone=None, latitude=None, longitude=None, homepage_content=None,
+ selfgenerated_bugnotifications=False, member_of=()):
"""Create and return a new, arbitrary Person.
:param email: The email address for the new person.
:param name: The name for the new person.
- :param password: Ignored.
:param email_address_status: If specified, the status of the email
address is set to the email_address_status.
:param displayname: The display name to use for the person.
=== modified file 'lib/lp/testing/pages.py'
--- lib/lp/testing/pages.py 2012-01-18 06:41:42 +0000
+++ lib/lp/testing/pages.py 2012-01-18 13:30:57 +0000
@@ -674,11 +674,10 @@
return browser
-def setupBrowserForUser(user, password='test'):
+def setupBrowserForUser(user):
"""Setup a browser grabbing details from a user.
:param user: The user to use.
- :param password: The password to use.
"""
naked_user = removeSecurityProxy(user)
email = naked_user.preferredemail.email
@@ -731,8 +730,7 @@
login('foo.bar@xxxxxxxxxxxxx')
try:
dtg_member = LaunchpadObjectFactory().makePerson(
- name='ubuntu-translations-coordinator',
- email="dtg-member@xxxxxx", password="test")
+ name='ubuntu-translations-coordinator', email="dtg-member@xxxxxx")
except NameAlreadyTaken:
# We have already created the translations coordinator
pass
@@ -753,8 +751,7 @@
login('admin@xxxxxxxxxxxxx')
try:
rosetta_expert = LaunchpadObjectFactory().makePerson(
- name='rosetta-experts-member',
- email='re@xxxxxx', password='test')
+ name='rosetta-experts-member', email='re@xxxxxx')
except NameAlreadyTaken:
# We have already created an Rosetta expert
pass
=== modified file 'lib/lp/translations/browser/tests/test_sharing_information.py'
--- lib/lp/translations/browser/tests/test_sharing_information.py 2012-01-01 02:58:52 +0000
+++ lib/lp/translations/browser/tests/test_sharing_information.py 2012-01-18 13:30:57 +0000
@@ -72,7 +72,7 @@
If productseries is None, return an arbritrary user. Used by
implementations of getAuthorizedUser.
"""
- logged_in_user = self.factory.makePerson(password='test')
+ logged_in_user = self.factory.makePerson()
if productseries is not None:
with celebrity_logged_in('admin'):
productseries.product.owner = logged_in_user
=== modified file 'lib/lp/translations/stories/buildfarm/xx-build-summary.txt'
--- lib/lp/translations/stories/buildfarm/xx-build-summary.txt 2011-12-22 05:37:22 +0000
+++ lib/lp/translations/stories/buildfarm/xx-build-summary.txt 2012-01-18 13:30:57 +0000
@@ -28,7 +28,7 @@
>>> login(ANONYMOUS)
>>> owner_email = factory.getUniqueString() + '@example.com'
- >>> owner = factory.makePerson(email=owner_email, password='test')
+ >>> owner = factory.makePerson(email=owner_email)
>>> productseries = factory.makeProductSeries(owner=owner)
>>> product = productseries.product
=== modified file 'lib/lp/translations/stories/importqueue/xx-translation-import-queue.txt'
--- lib/lp/translations/stories/importqueue/xx-translation-import-queue.txt 2010-08-06 09:32:02 +0000
+++ lib/lp/translations/stories/importqueue/xx-translation-import-queue.txt 2012-01-18 13:30:57 +0000
@@ -312,7 +312,7 @@
>>> package = factory.makeSourcePackageName()
>>> group_owner = factory.makePerson(
- ... email='go@xxxxxxxxxxx', name='groupowner', password='test')
+ ... email='go@xxxxxxxxxxx', name='groupowner')
>>> uploader = factory.makePerson()
>>> ubuntu.translationgroup = factory.makeTranslationGroup(group_owner)
>>> ubuntu_upload = queue.addOrUpdateEntry(
=== modified file 'lib/lp/translations/stories/productseries/xx-productseries-export-to-branch.txt'
--- lib/lp/translations/stories/productseries/xx-productseries-export-to-branch.txt 2012-01-15 10:25:39 +0000
+++ lib/lp/translations/stories/productseries/xx-productseries-export-to-branch.txt 2012-01-18 13:30:57 +0000
@@ -8,7 +8,7 @@
>>> from lp.app.enums import ServiceUsage
>>> login(ANONYMOUS)
- >>> owner = factory.makePerson(email='x@xxxxxxxxxxx', password='test')
+ >>> owner = factory.makePerson(email='x@xxxxxxxxxxx')
>>> product = factory.makeProduct(owner=owner,
... translations_usage=ServiceUsage.LAUNCHPAD)
>>> productseries = product.getSeries('trunk')
=== modified file 'lib/lp/translations/stories/productseries/xx-productseries-translations.txt'
--- lib/lp/translations/stories/productseries/xx-productseries-translations.txt 2011-12-08 18:33:45 +0000
+++ lib/lp/translations/stories/productseries/xx-productseries-translations.txt 2012-01-18 13:30:57 +0000
@@ -221,8 +221,7 @@
>>> login(admin_email)
>>> admin_user = getUtility(IPersonSet).getByEmail(admin_email)
- >>> jtv = factory.makePerson(
- ... email='jtv-sample@xxxxxxxxxxxxx', password='test')
+ >>> jtv = factory.makePerson(email='jtv-sample@xxxxxxxxxxxxx')
>>> celebs = getUtility(ILaunchpadCelebrities)
>>> membership = getUtility(ITeamMembershipSet).new(
... jtv, celebs.rosetta_experts, TeamMembershipStatus.APPROVED,
=== modified file 'lib/lp/translations/stories/standalone/custom-language-codes.txt'
--- lib/lp/translations/stories/standalone/custom-language-codes.txt 2011-08-03 11:00:11 +0000
+++ lib/lp/translations/stories/standalone/custom-language-codes.txt 2012-01-18 13:30:57 +0000
@@ -21,9 +21,8 @@
... return find_tag_by_id(browser.contents, 'custom-language-codes')
>>> login(ANONYMOUS)
- >>> owner = factory.makePerson(email='o@xxxxxxxxxxx', password='test')
- >>> rosetta_admin = factory.makePerson(
- ... email='r@xxxxxxxxxxx', password='test')
+ >>> owner = factory.makePerson(email='o@xxxxxxxxxxx')
+ >>> rosetta_admin = factory.makePerson(email='r@xxxxxxxxxxx')
>>> removeSecurityProxy(rosetta_admin).join(
... getUtility(ILaunchpadCelebrities).rosetta_experts)
>>> product = factory.makeProduct(displayname="Foo", owner=owner)
@@ -220,8 +219,7 @@
... distroseries=other_series,
... sourcepackagename=package.sourcepackagename),
... rootsite="translations")
- >>> translations_admin = factory.makePerson(
- ... email='ta@xxxxxxxxxxx', password='test')
+ >>> translations_admin = factory.makePerson(email='ta@xxxxxxxxxxx')
>>> translationgroup = factory.makeTranslationGroup(
... owner=translations_admin)
>>> removeSecurityProxy(distro).translationgroup = translationgroup
=== modified file 'lib/lp/translations/stories/standalone/xx-person-editlanguages.txt'
--- lib/lp/translations/stories/standalone/xx-person-editlanguages.txt 2010-12-18 09:53:45 +0000
+++ lib/lp/translations/stories/standalone/xx-person-editlanguages.txt 2012-01-18 13:30:57 +0000
@@ -203,8 +203,7 @@
Noi, a new user, visits her home page.
>>> login(ANONYMOUS)
- >>> noi = factory.makePerson(
- ... name='noi', email='noi@xxxxxxxxxxx', password='test')
+ >>> noi = factory.makePerson(name='noi', email='noi@xxxxxxxxxxx')
>>> logout()
>>> noi_browser = setupBrowser('Basic noi@xxxxxxxxxxx:test')
=== modified file 'lib/lp/translations/stories/standalone/xx-potemplate-admin.txt'
--- lib/lp/translations/stories/standalone/xx-potemplate-admin.txt 2011-12-08 18:40:33 +0000
+++ lib/lp/translations/stories/standalone/xx-potemplate-admin.txt 2012-01-18 13:30:57 +0000
@@ -205,10 +205,10 @@
>>> template = templatesubset.new(
... 'foo', 'foo', 'foo.pot', template_owner)
- >>> distro_owner = factory.makePerson('do@xxxxxxxxxxx', password='test')
+ >>> distro_owner = factory.makePerson('do@xxxxxxxxxxx')
>>> ubuntu.owner = distro_owner
- >>> group_owner = factory.makePerson('go@xxxxxxxxxxx', password='test')
+ >>> group_owner = factory.makePerson('go@xxxxxxxxxxx')
>>> translation_group = factory.makeTranslationGroup(group_owner)
>>> ubuntu.translationgroup = translation_group
>>> template_admin_url = str(
=== modified file 'lib/lp/translations/stories/standalone/xx-serieslanguage-index.txt'
--- lib/lp/translations/stories/standalone/xx-serieslanguage-index.txt 2011-05-27 19:53:20 +0000
+++ lib/lp/translations/stories/standalone/xx-serieslanguage-index.txt 2012-01-18 13:30:57 +0000
@@ -64,8 +64,7 @@
>>> st_coordinator = factory.makePerson(
... name="ubuntu-l10n-es",
... displayname='Ubuntu Spanish Translators')
- >>> dude = factory.makePerson(
- ... name="dude", email="dude@xxxxxx", password="test")
+ >>> dude = factory.makePerson(name="dude", email="dude@xxxxxx")
>>> ubuntu = getUtility(ILaunchpadCelebrities).ubuntu
>>> ubuntu.translationgroup = utg
>>> ubuntu.translationpermission = TranslationPermission.RESTRICTED
=== modified file 'lib/lp/translations/stories/standalone/xx-sourcepackage-export.txt'
--- lib/lp/translations/stories/standalone/xx-sourcepackage-export.txt 2012-01-15 11:06:57 +0000
+++ lib/lp/translations/stories/standalone/xx-sourcepackage-export.txt 2012-01-18 13:30:57 +0000
@@ -97,13 +97,15 @@
>>> ubuntu = getUtility(IDistributionSet).getByName('ubuntu')
>>> carlos = personset.getByName('carlos')
- >>> oofy = factory.makePerson(email='oofy@xxxxxxxxxxxxxxxxxx',
- ... name='oofy', password='test', displayname='Oofy Prosser')
+ >>> oofy = factory.makePerson(
+ ... email='oofy@xxxxxxxxxxxxxxxxxx', name='oofy',
+ ... displayname='Oofy Prosser')
>>> rosetta_admins = personset.getByName('rosetta-admins')
>>> ignored = rosetta_admins.addMember(oofy, carlos)
- >>> gussie = factory.makePerson(email='gussie@xxxxxxxxxxxxxxxxxx',
- ... name='gussie', password='test', displayname='Gussie Fink-Nottle')
+ >>> gussie = factory.makePerson(
+ ... email='gussie@xxxxxxxxxxxxxxxxxx', name='gussie',
+ ... displayname='Gussie Fink-Nottle')
>>> translators = factory.makeTeam(gussie)
>>> group = factory.makeTranslationGroup(translators)
=== modified file 'lib/lp/translations/stories/standalone/xx-translations-to-complete.txt'
--- lib/lp/translations/stories/standalone/xx-translations-to-complete.txt 2011-05-27 19:53:20 +0000
+++ lib/lp/translations/stories/standalone/xx-translations-to-complete.txt 2012-01-18 13:30:57 +0000
@@ -6,8 +6,7 @@
>>> from zope.security.proxy import removeSecurityProxy
>>> login(ANONYMOUS)
- >>> jean = factory.makePerson(
- ... name='jean', email='jean@xxxxxxxxxxx', password='test')
+ >>> jean = factory.makePerson(name='jean', email='jean@xxxxxxxxxxx')
Jean has been working on French translations for Foux in Launchpad.
@@ -52,8 +51,7 @@
Pierre is not a translator. Pierre does not get such a listing either.
>>> login(ANONYMOUS)
- >>> pierre = factory.makePerson(
- ... name='pierre', email='pierre@xxxxxxxxxxx', password='test')
+ >>> pierre = factory.makePerson(name='pierre', email='pierre@xxxxxxxxxxx')
>>> logout()
>>> pierre_browser = setupBrowser(auth='Basic pierre@xxxxxxxxxxx:test')
=== modified file 'lib/lp/translations/stories/standalone/xx-translations-to-review.txt'
--- lib/lp/translations/stories/standalone/xx-translations-to-review.txt 2010-12-25 21:28:14 +0000
+++ lib/lp/translations/stories/standalone/xx-translations-to-review.txt 2012-01-18 13:30:57 +0000
@@ -16,8 +16,7 @@
>>> login(ANONYMOUS)
- >>> user = factory.makePerson(
- ... name='xowxz', email='xowxz@xxxxxxxxxxx', password="test")
+ >>> user = factory.makePerson(name='xowxz', email='xowxz@xxxxxxxxxxx')
Xowxz is a Khmer reviewer.
=== modified file 'lib/lp/translations/stories/translationgroups/xx-change-translation-policy.txt'
--- lib/lp/translations/stories/translationgroups/xx-change-translation-policy.txt 2010-12-30 12:50:16 +0000
+++ lib/lp/translations/stories/translationgroups/xx-change-translation-policy.txt 2012-01-18 13:30:57 +0000
@@ -7,8 +7,7 @@
>>> from lp.app.enums import ServiceUsage
>>> login('admin@xxxxxxxxxxxxx')
- >>> product_owner = factory.makePerson(
- ... email="po@xxxxxx", password="test")
+ >>> product_owner = factory.makePerson(email="po@xxxxxx")
>>> chestii = factory.makeProduct(
... name='chestii',
... owner=product_owner,
=== modified file 'lib/lp/translations/windmill/tests/test_import_queue.py'
--- lib/lp/translations/windmill/tests/test_import_queue.py 2011-06-27 14:10:30 +0000
+++ lib/lp/translations/windmill/tests/test_import_queue.py 2012-01-18 13:30:57 +0000
@@ -60,7 +60,7 @@
def test_import_queue_status_nopriv(self):
"""Tests that a none-admin will have less choices."""
hubert = self.factory.makePerson(
- name="hubert", displayname="Hubert Hunt", password="test",
+ name="hubert", displayname="Hubert Hunt",
email="hubert@xxxxxxxxxxx")
# Create a project and an import entry with it.
product = self.factory.makeProduct(
=== modified file 'utilities/make-lp-user'
--- utilities/make-lp-user 2011-12-30 08:13:14 +0000
+++ utilities/make-lp-user 2012-01-18 13:30:57 +0000
@@ -57,7 +57,6 @@
_pythonpath = _pythonpath
-DEFAULT_PASSWORD = 'test'
factory = LaunchpadObjectFactory()
set_default_timeout_function(lambda: 100)
@@ -65,16 +64,11 @@
def make_person(username, email):
"""Create and return a person with the given username.
- The email address for the user will be <username>@example.com. The
- password will be the value of `DEFAULT_PASSWORD`.
-
- These details will be printed to stdout.
+ The email address for the user will be <username>@example.com.
"""
- person = factory.makePerson(
- name=username, password=DEFAULT_PASSWORD, email=email)
+ person = factory.makePerson(name=username, email=email)
print "username: %s" % (username,)
print "email: %s" % (email,)
- print "password: %s" % (DEFAULT_PASSWORD,)
return person
@@ -219,7 +213,7 @@
"""Run the script."""
options = parse_args(arguments)
if options.email is None:
- email = '%s@xxxxxxxxxxx' % options.username
+ email = '%s@xxxxxxxxxxx' % options.username
else:
email = options.email
