launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

The proposal to merge lp:~rharding/launchpad/resizing_fix_911853 into lp:launchpad has been updated.

Description changed to:

= Summary =
When adding a bug from Firefox the first time you typed into the box it jumped in size.

== Proposed Fix ==
Firefox wasn't keeping the min height setting because it was hidden beneath a div set to display: none.

== Implementation Details ==
When we run resize, make sure that the min height is always set by default for multi line inputs.

== Tests ==
firefox lib/lp/app/javascript/formwidgets/tests/test_resizing_textarea.html

== Demo and Q/A ==
Add a new bug in Firefox. When the textarea becomes visible, make sure it's set to the default height of 300px. Typing into the box should not move/adjust until it's hit the limits of the initial height.

== Lint ==
Linting changed files:
  lib/lp/app/javascript/formwidgets/resizing_textarea.js
  lib/lp/app/javascript/formwidgets/tests/test_resizing_textarea.html
  lib/lp/app/javascript/formwidgets/tests/test_resizing_textarea.js

For more details, see:
https://code.launchpad.net/~rharding/launchpad/resizing_fix_911853/+merge/89036
-- 
https://code.launchpad.net/~rharding/launchpad/resizing_fix_911853/+merge/89036
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rharding/launchpad/resizing_fix_911853 into lp:launchpad.