launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

The proposal to merge lp:~jcsackett/launchpad/collapse-team-tests into lp:launchpad has been updated.

Description changed to:

Summary
=======
Two test modules -- lp.registry.browser.tests.test_team and
lp.registry.browser.tests.test_team_view -- exist in the lp tree without any
clear difference between them. Consensus says that the two files lived in
different places and were dropped together during the apocalypse.

As an aftershock of the apocalypse, this branch merges them into
lp.registry.browser.tests.test_team.

This review appears to be huge--it's not, really, just a lot of LoC moved 
from one file to another.

Preimp
======
Spoke with Curtis Hovey

Implementation
==============
The two test cases from lp.registry.browser.tests.test_team_view were moved
into lp.registry.browser.tests.test_team. Imports were brought over, and
duplicates and formatting errors were dealt with via the import formatter. No
testcases seemed to be redundant, so none were removed. The reviewer is free
to indicate something is redundant, at which point it will be terminated with
prejudice.

Tests
=====
bin/test -vvcm lp.registry.browser.tests.test_team

QA
==
None

Lint
====
This branch is lint free.

For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/collapse-team-tests/+merge/89157
-- 
https://code.launchpad.net/~jcsackett/launchpad/collapse-team-tests/+merge/89157
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/collapse-team-tests into lp:launchpad.