launchpad-reviewers team mailing list archive

[James Westby <jw+debian@xxxxxxxxxxxxxxx>]

James Westby has proposed merging lp:~james-w/python-oops/update-readme-dependencies into lp:python-oops.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~james-w/python-oops/update-readme-dependencies/+merge/90028

Hi,

The setup.py doesn't mention that bson is needed, and the
README misses most of the dependencies.

Thanks,

James
-- 
https://code.launchpad.net/~james-w/python-oops/update-readme-dependencies/+merge/90028
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~james-w/python-oops/update-readme-dependencies into lp:python-oops.

=== modified file 'README'
--- README	2011-11-13 21:24:42 +0000
+++ README	2012-01-25 01:50:27 +0000
@@ -29,6 +29,9 @@
 ============
 
 * Python 2.6+
+* pytz (http://pypi.python.org/pypi/pytz/)
+* bson (http://pypi.python.org/pypi/bson)
+* iso8601 (http://pypi.python.org/pypi/iso8601)
 
 Testing Dependencies
 ====================

=== modified file 'setup.py'
--- setup.py	2011-11-13 21:28:06 +0000
+++ setup.py	2012-01-25 01:50:27 +0000
@@ -39,6 +39,7 @@
           'Programming Language :: Python',
           ],
       install_requires = [
+          'bson',
           'iso8601',
           'pytz',
           ],