launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/user-himself into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/user-himself/+merge/90376

Refer to the user as 'the user themself', rather than 'the user himself'. Disgraceful.
-- 
https://code.launchpad.net/~stevenk/launchpad/user-himself/+merge/90376
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/user-himself into lp:launchpad.

=== modified file 'lib/lp/registry/model/persontransferjob.py'
--- lib/lp/registry/model/persontransferjob.py	2012-01-17 21:45:24 +0000
+++ lib/lp/registry/model/persontransferjob.py	2012-01-27 06:26:24 +0000
@@ -1,4 +1,4 @@
-# Copyright 2010-2011 Canonical Ltd.  This software is licensed under the
+# Copyright 2010-2012 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Job classes related to PersonTransferJob."""
@@ -238,8 +238,7 @@
         if self.reviewer != self.member:
             self.reviewer_name = self.reviewer.unique_displayname
         else:
-            # The user himself changed his self.membership.
-            self.reviewer_name = 'the user himself'
+            self.reviewer_name = 'the user themself'
 
         if self.last_change_comment:
             comment = ("\n%s said:\n %s\n" % (