launchpad-reviewers team mailing list archive

[Richard Harding <rick.harding@xxxxxxxxxxxxx>]

Thanks for this event wiring Ian, much nicer. A couple of JS comments:

We're using Y.Lang.isValue() for our null/undefined checks. It checks for several values which is good to help prevent issues catching bad values.

For the test update, rather than putting in a fragile wait, you can include event-simulate and node-event-simulate and 

For the test update, rather than setting a timeout, you can use the async infrastructure using a wait/resume combination. See the examples here: http://yuilibrary.com/yui/docs/test/test-async-event-tests.html

This should make the tests a bit faster and less fragile depending on a MS value.
-- 
https://code.launchpad.net/~wallyworld/launchpad/global-yui-namespaces-gone/+merge/90385
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wallyworld/launchpad/global-yui-namespaces-gone into lp:launchpad.