launchpad-reviewers team mailing list archive

["j.c.sackett" <jcsackett@xxxxxxxxxxxxx>]

j.c.sackett has proposed merging lp:~jcsackett/launchpad/lp-for-preview-url into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #369750 in Launchpad itself: "Branch location preview should use lp: location"
  https://bugs.launchpad.net/launchpad/+bug/369750

For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/lp-for-preview-url/+merge/91507

This is a very simple branch; it just address a minor text inconsistency,
adding 'lp:' to the preview url given in +addbranch.

Previously this would say the new branch would be at
"~username/product/branch", not it says "lp:~username/product/branch".
-- 
https://code.launchpad.net/~jcsackett/launchpad/lp-for-preview-url/+merge/91507
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/lp-for-preview-url into lp:launchpad.

=== modified file 'lib/lp/code/javascript/util.js'
--- lib/lp/code/javascript/util.js	2012-01-17 07:24:43 +0000
+++ lib/lp/code/javascript/util.js	2012-02-03 21:33:39 +0000
@@ -16,7 +16,7 @@
     if (name == '') {
         name = '<name>';
     }
-    var branch_name = "~" + owner + "/" + target_name + "/" + name;
+    var branch_name = "lp:~" + owner + "/" + target_name + "/" + name;
     unique_name.set('text', branch_name);
 };