launchpad-reviewers team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

Aaron Bentley has proposed merging lp:~abentley/launchpad/stable-test-failures2 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #928308 in Launchpad itself: "timing-dependent failures in test_adapter.txt"
  https://bugs.launchpad.net/launchpad/+bug/928308

For more details, see:
https://code.launchpad.net/~abentley/launchpad/stable-test-failures2/+merge/92047

= Summary =
Fix bug #928308: timing-dependent failures in test_adapter.txt

== Proposed fix ==
Allow any arbitrary end time.

== Pre-implementation notes ==
None

== Implementation details ==
None

== Tests ==
bin/test -vt test_adapter.txt

== Demo and Q/A ==
None

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/services/webapp/doc/test_adapter.txt
-- 
https://code.launchpad.net/~abentley/launchpad/stable-test-failures2/+merge/92047
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~abentley/launchpad/stable-test-failures2 into lp:launchpad.

=== modified file 'lib/lp/services/webapp/doc/test_adapter.txt'
--- lib/lp/services/webapp/doc/test_adapter.txt	2011-12-30 06:47:17 +0000
+++ lib/lp/services/webapp/doc/test_adapter.txt	2012-02-08 15:23:28 +0000
@@ -338,7 +338,7 @@
 the database.
 
     >>> get_request_statements()
-    [(0, 0, 'SQL-main-master', 'SELECT 2', ...)]
+    [(0, ..., 'SQL-main-master', 'SELECT 2', ...)]
 
 
 When a RequestExpired exception is raised, the current