launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/fix-debug-timeline-js into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/fix-debug-timeline-js/+merge/92916

This branch fixes the debug_timeline JS. It never worked properly for me, and broke entirely once MochiKit disappeared. I've vaguely YUIfied it and also made it toggle and scroll.
-- 
https://code.launchpad.net/~wgrant/launchpad/fix-debug-timeline-js/+merge/92916
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/fix-debug-timeline-js into lp:launchpad.

=== modified file 'lib/lp/app/templates/launchpad-loginstatus.pt'
--- lib/lp/app/templates/launchpad-loginstatus.pt	2011-12-21 07:54:40 +0000
+++ lib/lp/app/templates/launchpad-loginstatus.pt	2012-02-14 06:21:20 +0000
@@ -10,7 +10,8 @@
   <form action="/+logout" method="post">
     <input type="hidden" name="loggingout" value="1" />
     <a
-      href="javascript:removeElementClass(document.getElementById('debug_timeline'),'hidden')"
+      href="javascript:void(0)"
+      onclick="window.scrollTo(0, LPJS.one('#debug_timeline').toggleClass('hidden').getXY()[1])"
       tal:condition="request/features/visible_render_time"
       >
       <div id="rendertime">Loading...</div>