launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #06402
[Merge] lp:~jcsackett/launchpad/trivially-add-sharing-ui-stuff into lp:launchpad
j.c.sackett has proposed merging lp:~jcsackett/launchpad/trivially-add-sharing-ui-stuff into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/trivially-add-sharing-ui-stuff/+merge/93501
Summary
=======
This branch just contains some placeholders for the thus far agreed upon
elements of the +sharing page's UI.
Implementation
==============
This branch just puts in the static, empty table and the side portlet
summarizing sharing data without the view populating the numbers.
There is other code in work to populate this data, but some of the data to
drive it is still in flux and I would rather get this landed to prevent
conflicts and blocking as purple team continues its work.
Tests
=====
There are no new tests; this branch just lands unchanging static HTML in some
templates, so there are no new moving parts to test.
QA
==
Make sure there's an empty table and side portlet on
qastaging.launchpad.dev/$product/+sharing
Lint
====
This branch is lint free.
--
https://code.launchpad.net/~jcsackett/launchpad/trivially-add-sharing-ui-stuff/+merge/93501
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/trivially-add-sharing-ui-stuff into lp:launchpad.
=== modified file 'lib/lp/registry/templates/product-sharing.pt'
--- lib/lp/registry/templates/product-sharing.pt 2012-02-13 19:29:29 +0000
+++ lib/lp/registry/templates/product-sharing.pt 2012-02-16 22:21:21 +0000
@@ -3,13 +3,75 @@
xmlns:tal="http://xml.zope.org/namespaces/tal";
xmlns:metal="http://xml.zope.org/namespaces/metal";
xmlns:i18n="http://xml.zope.org/namespaces/i18n";
- metal:use-macro="view/macro:page/main_only"
+ metal:use-macro="view/macro:page/main_side"
i18n:domain="launchpad"
>
<body>
<div metal:fill-slot="main">
- Proprietary, embargoed security, or user-data information about this project is shared with these users and teams.
+ <p>
+ Proprietary, embargoed security, or user-data information about this
+ project is shared with these users and teams.
+ </p>
+
+ <table id="observer-table" class="disclosure listing">
+ <thead>
+ <tr>
+ <th colspan="2" style="width: 33%">User or Team</th>
+ <th colspan="2" style="width: ">Sharing <span class="help">(<a href="permissions_help.html" target="help" class="js-action help">help</a>)</span></th>
+ <th colspan="1" style="width: ">Shared items</th>
+ </tr>
+ </thead>
+ <tbody id="observer-table-body"></tbody>
+ </table>
+ </div>
+
+ <div metal:fill-slot="side" tal:define="overview_menu context/menu:overview">
+ <tal:comment replace="nothing">
+ XXX j.c.sackett 2012-02-16 The data in this portlet is static right now,
+ as policy architecture (which determines the numbers to display) are in
+ flux. Once they settle down, the view needs to populate some methods to
+ set the numbers in this portlet.
+ </tal:comment>
+ <div id="portlet-disclosure-summary" class="first portlet">
+ <p>
+ Permavirgin is shared with <a href="#">0</a> users:
+ </p>
+
+ <table>
+ <thead>
+ <tr>
+ <td colspan="2"><strong>Embargoed Security:</strong></td>
+ </tr>
+ </thead>
+ <tbody>
+ <tr class="code-links">
+ <td>Sharing everything with <a href="#">0</a> users</td>
+ </tr>
+ <tr class="code-links">
+ <td>Sharing some things with <a href="#">0</a> users</td>
+ </tr>
+ </tbody>
+ </table>
+
+ <p></p>
+
+ <table>
+ <thead>
+ <tr>
+ <td colspan="2"><strong>User Data:</strong></td>
+ </tr>
+ </thead>
+ <tbody>
+ <tr class="code-links">
+ <td>Sharing everything with <a href="#">0</a> users</td>
+ </tr>
+ <tr class="code-links">
+ <td>Sharing some things with <a href="#">0</a> users</td>
+ </tr>
+ </tbody>
+ </table>
+ </div>
</div>
</body>
</html>
