launchpad-reviewers team mailing list archive

[Martin Pool <mbp@xxxxxxxxxxxxx>]

Martin Pool has proposed merging lp:~mbp/launchpad/remove-bsondump2 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~mbp/launchpad/remove-bsondump2/+merge/93778

This removes utilities/bsondump, which we agreed (in <https://code.launchpad.net/~mbp/python-oops-datedir-repo/bsondump/+merge/86338>) would be better off in python-oops-datedir-repo not in launchpad itself.

It also deletes less-oops.sh to which I'm fairly sure similar reasoning applies.
-- 
https://code.launchpad.net/~mbp/launchpad/remove-bsondump2/+merge/93778
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~mbp/launchpad/remove-bsondump2 into lp:launchpad.

=== removed file 'utilities/bsondump'
--- utilities/bsondump	2012-01-01 03:10:25 +0000
+++ utilities/bsondump	1970-01-01 00:00:00 +0000
@@ -1,9 +0,0 @@
-#! /usr/bin/python
-
-from pprint import pprint
-import sys
-
-import bson
-
-
-pprint(bson.decode_all(file(sys.argv[1], 'rb').read()))

=== removed file 'utilities/less-oops.sh'
--- utilities/less-oops.sh	2010-04-22 09:30:31 +0000
+++ utilities/less-oops.sh	1970-01-01 00:00:00 +0000
@@ -1,9 +0,0 @@
-#!/bin/bash
-#
-# Copyright 2009 Canonical Ltd.  This software is licensed under the
-# GNU Affero General Public License version 3 (see the file LICENSE).
-#
-# Outputs the contents of the OOPS report for a given OOPS ID.
-
-OOPS_ID=$1
-grep -rl "$OOPS_ID" /var/tmp/lperr* | xargs less