launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

> I haven't reviewed this, but I think storing pickles in the database is a bad
> idea. Once a non-built-in object has been pickled, we have to remember to
> never rename or move it in the code, and keep it compatible with the pickle,
> or we have to remember to write a custom unpickler. I think it would be much
> safer to use something like JSON so that we stick to basic, built-in, types.

Like I said on the MP, the goal is to store config values: list of strings, booleans, dict of string=>string not complex objects.  But it's easy to use json instead of pickle.  Maybe it's safer indeed.
-- 
https://code.launchpad.net/~rvb/maas/config-table/+merge/93861
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/config-table into lp:maas.