launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

I have no particular problem with pickling per se (apart from, well, yuck :).  But pickling arbitrary objects goes a bit far!  Somehow I had expected this to be for built-in types only.

Two other notes:

1. I'm not sure there's much value to documenting that a return type is "object," or that a parameter called "name" is of type str (which I suspect is actually incorrect and should be basestring instead so that we can use unicode).

2. Why the force_unicode?  I can't escape the impression that its only use here is to obscure the fact that UTF-8 is hard-coded as the encoding.
-- 
https://code.launchpad.net/~rvb/maas/config-table/+merge/93861
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/config-table into lp:maas.