launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

> You test the exact order in which the items are retrieved, but you neither
> specify nor test whether that is alphabetical order, creation order, or some
> other order.

Right, I've added sorted to remove the ambiguity.

> Moreover, the combination of "store lists as config values" and "store config
> values and I'll turn them into a list" seems destined to cause confusion, much
> like the trouble we had with Django's weird request parameter dicts.  What
> exactly is the overriding requirement?  Without one, I would say please keep
> it simple.  The need for this kind of thing would be useful to explain in your
> cover letter, i.e. the description on the MP.  But it's hard for me to judge
> without knowing more about the problem this branch solves.

Exactly, and I've done it that was for the very same reason.  I was sure you would recognized the pattern.
-- 
https://code.launchpad.net/~rvb/maas/config-table/+merge/93861
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/config-table into lp:maas.