launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/weird-lint into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jtv/maas/weird-lint/+merge/94757

Those two MACAddressForm classes look identical to me, and redundant.
-- 
https://code.launchpad.net/~jtv/maas/weird-lint/+merge/94757
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/weird-lint into lp:maas.

=== modified file 'src/maasserver/forms.py'
--- src/maasserver/forms.py	2012-02-21 13:48:31 +0000
+++ src/maasserver/forms.py	2012-02-27 12:39:19 +0000
@@ -52,11 +52,6 @@
         model = MACAddress
 
 
-class MACAddressForm(ModelForm):
-    class Meta:
-        model = MACAddress
-
-
 class MultipleMACAddressField(forms.MultiValueField):
     def __init__(self, nb_macs=1, *args, **kwargs):
         fields = [MACAddressFormField() for i in xrange(nb_macs)]