launchpad-reviewers team mailing list archive

[Jelmer Vernooij <jelmer@xxxxxxxxx>]

Jelmer Vernooij has proposed merging lp:~jelmer/launchpad/bzr-url-scheme-code-imports into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #942328 in Launchpad itself: "support importing from 'bzr:' URLs"
  https://bugs.launchpad.net/launchpad/+bug/942328

For more details, see:
https://code.launchpad.net/~jelmer/launchpad/bzr-url-scheme-code-imports/+merge/94887

Sourceforge provides access to its repositories over bzr:// (the bzr smart server protocol over TCP/IP).

This branch makes Launchpad Launchpad allow mirrorring from these kinds of URLs.
-- 
https://code.launchpad.net/~jelmer/launchpad/bzr-url-scheme-code-imports/+merge/94887
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jelmer/launchpad/bzr-url-scheme-code-imports into lp:launchpad.

=== modified file 'lib/lp/codehosting/codeimport/tests/test_worker.py'
--- lib/lp/codehosting/codeimport/tests/test_worker.py	2012-02-15 17:29:54 +0000
+++ lib/lp/codehosting/codeimport/tests/test_worker.py	2012-02-28 00:02:46 +0000
@@ -1415,6 +1415,7 @@
         self.assertBadUrl("svn+ssh://svn.example.com/bla")
         self.assertGoodUrl("git://git.example.com/repo")
         self.assertGoodUrl("https://hg.example.com/hg/repo/branch";)
+        self.assertGoodUrl("bzr://bzr.example.com/somebzrurl/")
 
 
 class RedirectTests(http_utils.TestCaseWithRedirectedWebserver, TestCase):

=== modified file 'lib/lp/codehosting/codeimport/worker.py'
--- lib/lp/codehosting/codeimport/worker.py	2012-01-01 07:14:04 +0000
+++ lib/lp/codehosting/codeimport/worker.py	2012-02-28 00:02:46 +0000
@@ -95,7 +95,7 @@
      - only open the allowed schemes
     """
 
-    allowed_schemes = ['http', 'https', 'svn', 'git', 'ftp']
+    allowed_schemes = ['http', 'https', 'svn', 'git', 'ftp', 'bzr']
 
     def shouldFollowReferences(self):
         """See `BranchOpenPolicy.shouldFollowReferences`.