launchpad-reviewers team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

The proposal to merge lp:~deryck/launchpad/preload-tags-for-buglistings-901122 into lp:launchpad has been updated.

Description changed to:

This is the first branch of refactorings to load new data that was added in new buglistings without adding more queries.  This first bit here is to get tags loaded as a set for a given buglisting batch, rather than accessing them in a loop for each item in the buglist.

I followed the pattern used for bug_badge_properties, which calls out to a method on IBugTaskSet to get bug badge data. In my case, I added tags_for_batch which calls out to IBugTaskSet.getBugTaskTags.  getBugTaskTags is where the query happens, and then _getListingItem uses tags_for_batch, which is cached, to get the tags for the listing item.

There were a few test updates required, since the required arguments changed for BugTaskListingItem.  I also updated doc/bugtask.txt to test the new BugTaskSet method.  Otherwise, it's a pretty straight forward change.

For more details, see:
https://code.launchpad.net/~deryck/launchpad/preload-tags-for-buglistings-901122/+merge/95023
-- 
https://code.launchpad.net/~deryck/launchpad/preload-tags-for-buglistings-901122/+merge/95023
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/preload-tags-for-buglistings-901122 into lp:launchpad.