launchpad-reviewers team mailing list archive

Thread
Date

[Merge] lp:~jcsackett/launchpad/sharing-help-is-caring into lp:launchpad

To: mp+95059@xxxxxxxxxxxxxxxxxx
From: "j.c.sackett" <jcsackett@xxxxxxxxxxxxx>
Date: Tue, 28 Feb 2012 21:45:37 -0000
Reply-to: mp+95059@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

j.c.sackett has proposed merging lp:~jcsackett/launchpad/sharing-help-is-caring into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #942678 in Launchpad itself: "+sharing help is missing"
  https://bugs.launchpad.net/launchpad/+bug/942678

For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/sharing-help-is-caring/+merge/95059

Summary
=======
Adds the help for +sharing

Implementation
==============
A new file, lib/lp/registry/help/sharing.html, has been added. It's a copy of the help file from the disclosure mockups Curtis Hovey has been working on.

The href for the sharing help has been updated to work with +help-registry

QA
==
Verify that the Help link on Product+sharing works.

Lint
====
This branch is lint free.
-- 
https://code.launchpad.net/~jcsackett/launchpad/sharing-help-is-caring/+merge/95059
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/sharing-help-is-caring into lp:launchpad.

=== added file 'lib/lp/registry/help/sharing.html'
--- lib/lp/registry/help/sharing.html	1970-01-01 00:00:00 +0000
+++ lib/lp/registry/help/sharing.html	2012-02-28 21:44:38 +0000
@@ -0,0 +1,89 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
+    "http://www.w3.org/TR/html4/loose.dtd";>
+<html>
+  <head>
+    <title>Sharing kinds of information</title>
+    <link type="text/css" rel="stylesheet"
+        media="screen, print" href="html_files/combo.css" />
+    <link type="text/css" rel="stylesheet"
+        media="screen, print" href="html_files/css.css" />
+  </head>
+  <body>
+    <h1>Sharing kinds of information</h1>
+    <div class="steps"><div style="width: 100%;" class="step-on"></div></div>
+
+    <p>
+        Launchpad has three kinds of restricted information &mdash;
+        proprietary, embargoed and user-data. You'll only see them if they're
+        shared with you.
+    </p>
+
+    <p>
+        There are also three ways to share &mdash; share all, share some or
+        share none.
+    </p>
+
+    <h3>Share some</h3>
+
+    <p>
+        If you are a project maintainer, you may need to share a single bug or
+        branch within a project a user or team to address an issue. You can
+        share proprietary, embargoed security, or user-data bugs and branches
+        by subscribing users and teams to the bug or branch. You can then view
+        the exceptional bugs and branches that you've shared.
+    </p>
+
+
+    <h2>Kinds of information</h2>
+
+    <dl>
+        <dt>Proprietary</dt>
+        <dd>
+            Information owned by an organisation, held in confidence. Visible
+            to people affiliated with the project and its organisation.
+        </dd>
+
+        <dt>Embargoes Security</dt>
+        <dd>
+            Visible if you're involved in fixing and deploying critical
+            vulnerability and exploits
+            (<a class="sprite external-link"
+                href="http://cve.mitre.org/";>CVEs</a>). Embargo will be lifted
+            after the fixes have been made, so that the information is visible
+            to anyone who may need to ensure that their version is secure.
+        </dd>
+
+        <dt>User-data</dt>
+        <dd>
+            Information containing personal data. Visible if you're working
+            with or able to remove, the personal data from the information. It
+            can only be made public after the personal data is removed.
+        </dd>
+
+    </dl>
+
+    <h2>Sharing</h2>
+
+    <dl>
+        <dt>All</dt>
+        <dd>
+            All proprietary, embargoed security, or user-data project
+            information is shared.
+        </dd>
+
+        <dt>Some</dt>
+        <dd>
+            Some Proprietary, embargoed security, or user-data project
+            information is shared via a bug or branch subscription.
+        </dd>
+
+        <dt>Nothing</dt>
+        <dd>
+            No Proprietary, embargoed security, or user-data project
+            information is shared.
+        </dd>
+    </dl>
+
+
+  </body>
+</html>

=== modified file 'lib/lp/registry/templates/product-sharing.pt'
--- lib/lp/registry/templates/product-sharing.pt	2012-02-22 05:22:13 +0000
+++ lib/lp/registry/templates/product-sharing.pt	2012-02-28 21:44:38 +0000
@@ -32,7 +32,10 @@
       <thead>
         <tr>
           <th colspan="2" style="width: 33%">User or Team</th>
-          <th colspan="2" style="width: ">Sharing <span class="help">(<a href="permissions_help.html" target="help" class="js-action help">help</a>)</span></th>
+          <th colspan="2" style="width: ">Sharing <span class="help">
+            (<a href="/+help-registry/sharing.html"
+              target="help" class="js-action help">help</a>)</span>
+          </th>
           <th colspan="1" style="width: ">Shared items</th>
         </tr>
       </thead>