launchpad-reviewers team mailing list archive

[Deryck Hodge <deryck.hodge@xxxxxxxxxxxxx>]

The proposal to merge lp:~deryck/launchpad/adapt-badges-listing-item-901122 into lp:launchpad has been updated.

Description changed to:

This is the second and final branch in getting the new bug data we added in custom buglistings loading with less queries.  This is a simple one line fix with a lot of power.  There's already a class to ensure we don't issue too many queries when getting badges.  See lp.app.browser.tales.BugTaskListingItemImageDisplayAPI.  But there is also it's super class lp.app.browser.tales.BugTaskImageDisplayAPI.  Since we were adapting based on bugtasks rather than self (which is the BugTaskListingItem) we were adapting to the super class and not BugTaskListingItemImageDisplayAPI, which is the class that helps us avoid the additional queries.

This fix is magical.  It brings us back down to pre-custom buglistings query levels +2.  But the +2 is consistent no matter the data size, and are attributed to cached queries to get tags and reporter name.

lifeless suggested I add a scaling test in the pre-req branch for this one, which I'll gladly add into this branch before considering the work done.

For more details, see:
https://code.launchpad.net/~deryck/launchpad/adapt-badges-listing-item-901122/+merge/95063
-- 
https://code.launchpad.net/~deryck/launchpad/adapt-badges-listing-item-901122/+merge/95063
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~deryck/launchpad/adapt-badges-listing-item-901122 into lp:launchpad.