← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~jcsackett/launchpad/yellow-is-revolting into lp:launchpad

 

j.c.sackett has proposed merging lp:~jcsackett/launchpad/yellow-is-revolting into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jcsackett/launchpad/yellow-is-revolting/+merge/95689

Summary
=======
The "hidden comment" color on bug comments is a revolting yellow generally
likened to urine. No one has liked it from the moment we could hide comments.

This turns it to gray. That's it.

Implementation
==============
Changed the css rule.

QA
==
Hide a comment. Determine whether or not the new color burns your eyes.
-- 
https://code.launchpad.net/~jcsackett/launchpad/yellow-is-revolting/+merge/95689
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jcsackett/launchpad/yellow-is-revolting into lp:launchpad.
=== modified file 'lib/canonical/launchpad/icing/style.css'
--- lib/canonical/launchpad/icing/style.css	2011-12-07 04:57:36 +0000
+++ lib/canonical/launchpad/icing/style.css	2012-03-02 23:01:18 +0000
@@ -254,7 +254,7 @@
   border-top: 1px solid #ddd;
 }
 .from-superseded {background-color: #ffffcc;}
-.adminHiddenComment {background-color:yellow;}
+.adminHiddenComment {background-color:gray;}
 
 /* --- Overview --- */