launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/maas/filestorage-gc into lp:maas has been updated.

Description changed to:

In implementing the overwriting of stored files, I created a problem: what happens to uploaded files that have been overwritten from the client's point of view, and can no longer be accessed?

This branch does not solve that problem.  But it does implement a method you can call to take care of the problem: FileStorage.objects.collect_garbage().  I'm not sure who's going to call this method yet, but that's a separate ticket.

There's a lot of testing in this branch.  Some might say too much.  But think about it: deleting files from the filesystem is not an action to perform sloppily.  I tested the essential behaviours before I wrote the code, and there just happened to be a lot of essential behaviours.

For more details, see:
https://code.launchpad.net/~jtv/maas/filestorage-gc/+merge/95696
-- 
https://code.launchpad.net/~jtv/maas/filestorage-gc/+merge/95696
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/filestorage-gc into lp:maas.