launchpad-reviewers team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

The proposal to merge lp:~allenap/txlongpoll/config-file into lp:txlongpoll has been updated.

Description changed to:

This changes txlongpoll to use a config file (yaml, though the validation is format agnostic) in the same way that maas is using a config file (and where it's working well). It's also changes the semi-broken getRotatableLogFileObserver() and setUpOOPSHandler() to run as services. Again, this approach is copied from maas.

As a lot of this code has come from maas, it has already been reviewed. In particular,
txlongpoll/services.py and txlongpoll/tests/test_services.py are very similar.

For more details, see:
https://code.launchpad.net/~allenap/txlongpoll/config-file/+merge/97079
-- 
https://code.launchpad.net/~allenap/txlongpoll/config-file/+merge/97079
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/txlongpoll/config-file into lp:txlongpoll.