launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #06682
[Merge] lp:~stevenk/launchpad/destroy-ie-regression into lp:launchpad
Steve Kowalik has proposed merging lp:~stevenk/launchpad/destroy-ie-regression into lp:launchpad.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~stevenk/launchpad/destroy-ie-regression/+merge/97337
Death to all Y.UA.ie blocks that I felt comfortable destroying.
I have left two:
lib/lp/app/javascript/gallery-accordion/gallery-accordion.js: This use looked magical, and the gallery-accordian is ... thpecial, so I left it alone.
lib/lp/app/javascript/autocomplete/autocomplete.js: This use has special behaviour for IE only, and my JS skills failed me in trying to puzzle it out.
--
https://code.launchpad.net/~stevenk/launchpad/destroy-ie-regression/+merge/97337
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/destroy-ie-regression into lp:launchpad.
=== modified file 'lib/lp/app/javascript/autocomplete/autocomplete.js'
--- lib/lp/app/javascript/autocomplete/autocomplete.js 2011-06-29 14:56:15 +0000
+++ lib/lp/app/javascript/autocomplete/autocomplete.js 2012-03-14 03:40:25 +0000
@@ -152,16 +152,6 @@
initializer: function() {
// The widget starts out hidden.
this.hide();
-
- // XXX mars 2009-03-30 bug=352022
- // Disable the widget in Opera, as the NodeMenuNav plugin we use for
- // the autocomplete is so slow as to be broken.
- // As for IE, well, it's the usual story.
- if (Y.UA.opera || Y.UA.ie) {
- this.disable();
- // Also disable rendering using a NOP function.
- this.render = function() {};
- }
},
/**
=== modified file 'lib/lp/app/javascript/choice.js'
--- lib/lp/app/javascript/choice.js 2011-04-19 18:03:50 +0000
+++ lib/lp/app/javascript/choice.js 2012-03-14 03:40:25 +0000
@@ -22,11 +22,6 @@
}
namespace.addBinaryChoice = function(config, resource_uri, attribute) {
-
- if (Y.UA.ie) {
- return;
- }
-
var widget = new Y.ChoiceSource(config);
widget.plug({
fn: Y.lp.client.plugins.PATCHPlugin,
=== modified file 'lib/lp/app/javascript/inlineedit/editor.js'
--- lib/lp/app/javascript/inlineedit/editor.js 2012-03-06 18:13:52 +0000
+++ lib/lp/app/javascript/inlineedit/editor.js 2012-03-14 03:40:25 +0000
@@ -1199,13 +1199,6 @@
// effectively shuts down the widget. See bug #331584.
e.preventDefault();
}
-
- // XXX JeroenVermeulen 2009-03-11 bug=341098: The editor breaks
- // in IE. Fix the bug, or at least narrow this down to fewer IE
- // versions.
- if (Y.UA.ie) {
- e.preventDefault();
- }
},
/**
@@ -1376,7 +1369,7 @@
* @method renderer
*/
renderer: function() {
- if (this.editor.get(MULTILINE) && (Y.UA.ie || Y.UA.opera)) {
+ if (this.editor.get(MULTILINE) && Y.UA.opera) {
return;
}
EditableText.superclass.renderer.apply(this, arguments);
=== modified file 'lib/lp/app/javascript/multicheckbox.js'
--- lib/lp/app/javascript/multicheckbox.js 2012-01-11 13:10:45 +0000
+++ lib/lp/app/javascript/multicheckbox.js 2012-03-14 03:40:25 +0000
@@ -23,11 +23,6 @@
items, help_text, resource_uri, attribute_name, attribute_type,
content_box_id, config, client) {
-
- if (Y.UA.ie) {
- return;
- }
-
// We may have been passed a mock client for testing but if not, create
// a proper one.
if (client === undefined)
@@ -98,10 +93,6 @@
* a single string argument.
*/
namespace.create = function (attribute_name, items, help_text, config) {
- if (Y.UA.ie) {
- return;
- }
-
if (config !== undefined) {
var header = 'Choose an item.';
if (config.header !== undefined) {
=== modified file 'lib/lp/app/javascript/picker/picker_patcher.js'
--- lib/lp/app/javascript/picker/picker_patcher.js 2012-02-22 05:31:47 +0000
+++ lib/lp/app/javascript/picker/picker_patcher.js 2012-03-14 03:40:25 +0000
@@ -56,9 +56,6 @@
* @param show_widget_id the id of the Choose... link
*/
namespace.addPicker = function(config, show_widget_id) {
- if (Y.UA.ie) {
- return;
- }
_addPicker(config, show_widget_id);
Y.on('lp.widget.connect', function(e) {
_addPicker(config, show_widget_id);
@@ -99,10 +96,6 @@
vocabulary, resource_uri, attribute_name,
content_box_id, config) {
- if (Y.UA.ie) {
- return;
- }
-
var null_display_value = 'None';
var show_search_box = true;
var vocabulary_filters;
@@ -411,10 +404,6 @@
*/
namespace.create = function (vocabulary, config, associated_field_id,
vocabulary_filters) {
- if (Y.UA.ie) {
- return;
- }
-
var header = 'Choose an item.';
var step_title = "Enter search terms";
var picker_type = "default";
=== modified file 'lib/lp/app/templates/inline-multicheckbox-widget.pt'
--- lib/lp/app/templates/inline-multicheckbox-widget.pt 2012-02-01 15:31:32 +0000
+++ lib/lp/app/templates/inline-multicheckbox-widget.pt 2012-03-14 03:40:25 +0000
@@ -32,10 +32,6 @@
<script tal:condition="view/can_write"
tal:content="string:
LPJS.use('lp.app.multicheckbox', function(Y) {
- if (Y.UA.ie) {
- return;
- }
-
Y.on('load', function(e) {
Y.lp.app.multicheckbox.addMultiCheckboxPatcher(
${view/json_items},
=== modified file 'lib/lp/app/templates/inline-picker.pt'
--- lib/lp/app/templates/inline-picker.pt 2012-02-01 15:31:32 +0000
+++ lib/lp/app/templates/inline-picker.pt 2012-03-14 03:40:25 +0000
@@ -30,10 +30,6 @@
<script tal:condition="view/can_write"
tal:content="structure string:
LPJS.use('lp.app.picker', 'lp.client', function(Y) {
- if (Y.UA.ie) {
- return;
- }
-
var picker_config = ${view/json_config}
picker_config.validate_callback = Y.lp.app.picker.public_private_warning;
Y.on('load', function(e) {
=== modified file 'lib/lp/app/widgets/templates/bugtracker-picker.pt'
--- lib/lp/app/widgets/templates/bugtracker-picker.pt 2012-02-01 15:31:32 +0000
+++ lib/lp/app/widgets/templates/bugtracker-picker.pt 2012-03-14 03:40:25 +0000
@@ -6,9 +6,6 @@
<metal:form-picker use-macro="context/@@form-picker-macros/form-picker"/>
<script tal:content="structure string:
LPJS.use('lp.bugs.bugtracker_overlay', function(Y) {
- if (Y.UA.ie) {
- return;
- }
Y.on('domready', function () {
// After the success handler finishes, it calls the
// next_step function.
=== modified file 'lib/lp/bugs/javascript/bugtask_index.js'
--- lib/lp/bugs/javascript/bugtask_index.js 2012-02-01 23:40:45 +0000
+++ lib/lp/bugs/javascript/bugtask_index.js 2012-03-14 03:40:25 +0000
@@ -47,9 +47,6 @@
* for these forms.
*/
Y.on('load', function() {
- if (Y.UA.ie) {
- return;
- }
// If the user is not logged in, then we need to defer to the
// default behaviour.
if (LP.links.me === undefined) {
@@ -885,10 +882,6 @@
* @method setup_bugtasks_row
*/
namespace.setup_bugtask_row = function(conf) {
- if (Y.UA.ie) {
- return;
- }
-
var tr = Y.one('#' + conf.row_id);
var bugtarget_content = Y.one('#bugtarget-picker-' + conf.row_id);
var status_content = tr.one('.status-content');
@@ -1189,10 +1182,6 @@
* @method setup_me_too
*/
namespace.setup_me_too = function(user_is_affected, others_affected_count) {
- // IE (7 & 8 tested) is stupid, stupid, stupid.
- if (Y.UA.ie) {
- return;
- }
var me_too_content = Y.one('#affectsmetoo');
var me_too_edit = new MeTooChoiceSource({
contentBox: me_too_content, value: user_is_affected,
=== modified file 'lib/lp/bugs/javascript/bugtracker_overlay.js'
--- lib/lp/bugs/javascript/bugtracker_overlay.js 2011-08-09 14:18:02 +0000
+++ lib/lp/bugs/javascript/bugtracker_overlay.js 2012-03-14 03:40:25 +0000
@@ -107,9 +107,6 @@
*/
namespace.attach_widget = function(config) {
Y.log('lp.bugs.bugtracker_overlay.attach_widget()');
- if (Y.UA.ie) {
- return;
- }
if (config === undefined) {
throw new Error(
"Missing attach_widget config for bugtracker_overlay.");
=== modified file 'lib/lp/code/javascript/branch.subscription.js'
--- lib/lp/code/javascript/branch.subscription.js 2011-08-09 14:18:02 +0000
+++ lib/lp/code/javascript/branch.subscription.js 2012-03-14 03:40:25 +0000
@@ -197,10 +197,6 @@
bindUI: function() {
var form_overlay = this._form_overlay;
this.get("self_subscribe").on('click', function(e) {
- // IE tables don't support innerHTML after render.
- if (Y.UA.ie) {
- return;
- }
e.halt();
form_overlay.show();
});
=== modified file 'lib/lp/code/javascript/branchmergeproposal.diff.js'
--- lib/lp/code/javascript/branchmergeproposal.diff.js 2011-11-16 14:10:32 +0000
+++ lib/lp/code/javascript/branchmergeproposal.diff.js 2012-03-14 03:40:25 +0000
@@ -135,11 +135,6 @@
* Connect the diff links to their pretty overlay function.
*/
namespace.connect_diff_links = function() {
- // IE doesn't like pretty overlays.
- if (Y.UA.ie) {
- return;
- }
-
// Setup the LP client.
var lp_client = new Y.lp.client.Launchpad();
=== modified file 'lib/lp/code/templates/branch-related-bugs-specs.pt'
--- lib/lp/code/templates/branch-related-bugs-specs.pt 2012-03-01 21:50:42 +0000
+++ lib/lp/code/templates/branch-related-bugs-specs.pt 2012-03-14 03:40:25 +0000
@@ -75,10 +75,6 @@
LPJS.use('io-base', 'lp.code.branch.bugspeclinks', function(Y) {
- if(Y.UA.ie) {
- return;
- }
-
Y.on('domready', function() {
var logged_in = LP.links['me'] !== undefined;
=== modified file 'lib/lp/code/templates/branchmergeproposal-index.pt'
--- lib/lp/code/templates/branchmergeproposal-index.pt 2012-02-01 15:31:32 +0000
+++ lib/lp/code/templates/branchmergeproposal-index.pt 2012-03-14 03:40:25 +0000
@@ -217,11 +217,6 @@
if (logged_in) {
var comment = new Y.lp.app.comment.CodeReviewComment();
comment.render();
-
- if(Y.UA.ie) {
- return;
- }
-
Y.lp.code.branchmergeproposal.status.connect_status(conf);
}
Y.lp.code.branchmergeproposal.reviewcomment.connect_links();
=== modified file 'lib/lp/code/templates/sourcepackagerecipe-index.pt'
--- lib/lp/code/templates/sourcepackagerecipe-index.pt 2012-02-01 15:31:32 +0000
+++ lib/lp/code/templates/sourcepackagerecipe-index.pt 2012-03-14 03:40:25 +0000
@@ -157,10 +157,6 @@
Y.on('lp:context:base_branch_link:changed', function(e) {
Y.lp.ui.update_field('#base-branch dd', e.new_value_html);
});
-
- if(Y.UA.ie) {
- return;
- }
Y.on('load', function() {
var logged_in = LP.links['me'] !== undefined;
if (logged_in) {
=== modified file 'lib/lp/registry/javascript/milestoneoverlay.js'
--- lib/lp/registry/javascript/milestoneoverlay.js 2012-01-11 10:39:27 +0000
+++ lib/lp/registry/javascript/milestoneoverlay.js 2012-03-14 03:40:25 +0000
@@ -191,9 +191,6 @@
* the milestone is created.
*/
module.attach_widget = function(config) {
- if (Y.UA.ie) {
- return;
- }
configure(config);
config.activate_node.on('click', show_milestone_form);
};
=== modified file 'lib/lp/registry/javascript/team.js'
--- lib/lp/registry/javascript/team.js 2012-03-05 15:34:57 +0000
+++ lib/lp/registry/javascript/team.js 2012-03-14 03:40:25 +0000
@@ -15,10 +15,6 @@
* @method setup_add_member_handler
*/
module.setup_add_member_handler = function(step_title) {
- if (Y.UA.ie) {
- return;
- }
-
var config = {
header: 'Add a member',
step_title: step_title,
=== modified file 'lib/lp/registry/templates/object-timeline-graph.pt'
--- lib/lp/registry/templates/object-timeline-graph.pt 2012-02-01 15:31:32 +0000
+++ lib/lp/registry/templates/object-timeline-graph.pt 2012-03-14 03:40:25 +0000
@@ -50,10 +50,6 @@
LPJS.use('lp.registry.timeline', 'node', 'lp.app.dragscroll', 'lp.client',
function(Y) {
Y.on('domready', function(e) {
- if (Y.UA.ie) {
- return;
- }
-
var display_graph = function(result) {
// The result for a single productseries needs to be
// wrapped in an array just as all the series for a
=== modified file 'lib/lp/registry/templates/productrelease-add-from-series.pt'
--- lib/lp/registry/templates/productrelease-add-from-series.pt 2012-02-01 15:31:32 +0000
+++ lib/lp/registry/templates/productrelease-add-from-series.pt 2012-03-14 03:40:25 +0000
@@ -56,9 +56,7 @@
next_step: add_milestone_to_menu,
activate_node: create_milestone_link
};
- if (!Y.UA.ie) {
- Y.lp.registry.milestoneoverlay.attach_widget(config);
- }
+ Y.lp.registry.milestoneoverlay.attach_widget(config);
});
});
-->
=== modified file 'lib/lp/registry/templates/timeline-macros.pt'
--- lib/lp/registry/templates/timeline-macros.pt 2012-02-01 15:31:32 +0000
+++ lib/lp/registry/templates/timeline-macros.pt 2012-03-14 03:40:25 +0000
@@ -46,9 +46,6 @@
timeline_url += "size=" + size + "&";
}
LPJS.use('node', function(Y) {
- if (Y.UA.ie) {
- return;
- }
var loading_el = Y.one('#timeline-loading');
loading_el.setStyle('display', 'block');
var iframe = Y.one('#timeline-iframe');
