launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/sharing-beta-banner into lp:launchpad with lp:~wallyworld/launchpad/sharing-view-readonly-956571 as a prerequisite.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/sharing-beta-banner/+merge/97801

Enable the beta banner on +sharing. This uses the infrastructure added by bug-columns to automatically display a banner when the flags differ from their default value.
-- 
https://code.launchpad.net/~wgrant/launchpad/sharing-beta-banner/+merge/97801
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/sharing-beta-banner into lp:launchpad.

=== modified file 'lib/lp/registry/browser/pillar.py'
--- lib/lp/registry/browser/pillar.py	2012-03-16 06:40:23 +0000
+++ lib/lp/registry/browser/pillar.py	2012-03-16 06:40:25 +0000
@@ -224,6 +224,11 @@
     page_title = "Sharing"
     label = "Sharing information"
 
+    related_features = (
+        'disclosure.enhanced_sharing.enabled',
+        'disclosure.enhanced_sharing.writable',
+        )
+
     def _getSharingService(self):
         return getUtility(IService, 'sharing')
 

=== modified file 'lib/lp/services/features/flags.py'
--- lib/lp/services/features/flags.py	2012-03-16 06:40:23 +0000
+++ lib/lp/services/features/flags.py	2012-03-16 06:40:25 +0000
@@ -292,14 +292,14 @@
      ('If true, will allow the use of the new sharing view and apis used '
       'for the new disclosure data model to view but not write data.'),
      '',
-     '',
+     'Sharing overview',
      ''),
     ('disclosure.enhanced_sharing.writable',
      'boolean',
      ('If true, will allow the use of the new sharing view and apis used '
       'to edit the new disclosure data model.'),
      '',
-     '',
+     'Sharing management',
      ''),
     ('garbo.workitem_migrator.enabled',
      'boolean',