launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #06797
Re: [Merge] lp:~julian-edwards/maas/vdenv-enlistment into lp:maas
On Tuesday 20 March 2012 15:50:23 you wrote:
> I like Gavin's solution of reconciling Cobbler and MAAS view using the
> Provisioning API. Turning this into a specific command that is run as part
> of vdenv is probably the direction to take. I say specific because I don't
> think we want to support general reconciliation where people starts adding
> stuff to Cobbler and expects to be able to sync MAAS with it. But as part
> of the vdenv setup, that should be fine.
The *right* fix here is to replicate all the data in cobbler that we also need
in Maas, and then fix the setup script in vdenv to poke them nodes directly
into MAAS using the API. MAAS will then update cobbler itself.
AFAIK, the only missing data is the virsh parameters, MAAS takes everything
else.
My branch was meant as a quick stopgap to get us up and running quicker.
>
> Looking at both Gavin's diff and yours, I have big concerns about the status
> change. This seems to implied that there is currently no way for nodes to
> go from DECLARED to READY. How is that supposed to work in the normal case?
Correct, this is an oversight at the moment. I am not sure this is covered in
any stories either :/
> Maybe that points to the fact that were aren't doing any commissioning yet?
Right.
Maybe we should default to READY now until commissioning is worked on?
--
https://code.launchpad.net/~julian-edwards/maas/vdenv-enlistment/+merge/98393
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~julian-edwards/maas/vdenv-enlistment into lp:maas.
Follow ups
References