launchpad-reviewers team mailing list archive

["Francis J. Lacoste" <francis.lacoste@xxxxxxxxxx>]

Hi Gavin,

Thanks for the fixes! I didn't spot the --terminate option!

On 12-03-21 10:18 AM, Gavin Panella wrote:
> -        self.addCleanup(service.group.Reset)
> +        self.addCleanup(service.unpublish)

Right, the reason I used service.group.Reset instead of unpublish was
that unpublish was an empty stub when the test was written. Maybe, it's
not important once unpublish is written.

-- 
Francis J. Lacoste
francis.lacoste@xxxxxxxxxxxxx


https://code.launchpad.net/~allenap/maas/some-lint-that-i-could-not-resist-fixing/+merge/98640
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/maas/some-lint-that-i-could-not-resist-fixing into lp:maas.