launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #06826
Re: [Merge] lp:~allenap/maas/some-lint-that-i-could-not-resist-fixing into lp:maas
> On 12-03-21 10:18 AM, Gavin Panella wrote:
> > - self.addCleanup(service.group.Reset)
> > + self.addCleanup(service.unpublish)
>
> Right, the reason I used service.group.Reset instead of unpublish was
> that unpublish was an empty stub when the test was written. Maybe, it's
> not important once unpublish is written.
It seems to be doing the right thing now...
--
https://code.launchpad.net/~allenap/maas/some-lint-that-i-could-not-resist-fixing/+merge/98640
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/maas/some-lint-that-i-could-not-resist-fixing into lp:maas.
References