launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/ready-by-default into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~jtv/maas/ready-by-default/+merge/98806

Nodes were previously Declared by default, but since we currently have no provisioning process to separate that state from Ready, for now they should be Ready by default.
-- 
https://code.launchpad.net/~jtv/maas/ready-by-default/+merge/98806
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/ready-by-default into lp:maas.

=== modified file 'src/maasserver/models.py'
--- src/maasserver/models.py	2012-03-21 14:20:54 +0000
+++ src/maasserver/models.py	2012-03-22 09:49:22 +0000
@@ -96,7 +96,9 @@
 
 class NODE_STATUS:
     """The vocabulary of a `Node`'s possible statuses."""
-    DEFAULT_STATUS = 0
+    # A node starts out as READY.
+    DEFAULT_STATUS = 4
+
     #: The node has been created and has a system ID assigned to it.
     DECLARED = 0
     #: Testing and other commissioning steps are taking place.

=== modified file 'src/maasserver/tests/test_models.py'
--- src/maasserver/tests/test_models.py	2012-03-19 15:41:55 +0000
+++ src/maasserver/tests/test_models.py	2012-03-22 09:49:22 +0000
@@ -71,7 +71,7 @@
     def test_display_status(self):
         node = factory.make_node()
         self.assertEqual(
-            NODE_STATUS_CHOICES_DICT[NODE_STATUS.DECLARED],
+            NODE_STATUS_CHOICES_DICT[NODE_STATUS.DEFAULT_STATUS],
             node.display_status())
 
     def test_add_mac_address(self):