launchpad-reviewers team mailing list archive

[Benji York <benji@xxxxxxxxxxxxx>]

Benji York has proposed merging lp:~benji/launchpad/bug-953913 into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~benji/launchpad/bug-953913/+merge/99120

During the Yellow squad's work we have found many tests that have
inter-test dependencies, this branch fixes one of them.

When run independently the TestTranslationTemplateChangeJob.test_splits_and_merges
test fails (intermittently for some, consistently for others).  It turns
out that the test fails because the sharingKey value can vary between
runs.  This branch makes the sharingKey consistent so the values the
test verifies are consistent from one run to another.

Tests:

    bin/test -c -t lp.translations.tests.test_translationpackagingjob.TestTranslationTemplateChangeJob.test_splits_and_merges

Lint: the lint report is clean

QA: none

-- 
https://code.launchpad.net/~benji/launchpad/bug-953913/+merge/99120
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~benji/launchpad/bug-953913 into lp:launchpad.