launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/maas/noticeable-add-node-errors into lp:maas has been updated.

Description changed to:

Okay, I'll admit it: this is not my work.

Francis added a comment on a different but related bug I was fixing, pointing out that global form errors on the add-node form (as distinct from field-specific errors) don't stand out at all.  You'll almost certainly miss them because they appear in the same style as regular text.

Most of the work I did on this is to put a ticket for that note on the kanban board.  Raphaël then wrote up a diff for the CSS, and posted a link to it on my MP.

All I did was more or less hand-apply the diff.  This may conflict with trunk initially, since my other branch will land in the meantime.

We may still have to reconsider the styling: to me, the styling of errors is very hard to distinguish from that of the “add another MAC” action link on the same form.

Jeroen

For more details, see:
https://code.launchpad.net/~jtv/maas/noticeable-add-node-errors/+merge/99256
-- 
https://code.launchpad.net/~jtv/maas/noticeable-add-node-errors/+merge/99256
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/noticeable-add-node-errors into lp:maas.