launchpad-reviewers team mailing list archive

[Diogo Matsubara <matsubara@xxxxxxxxxxxxx>]

Diogo Matsubara has proposed merging lp:~matsubara/maas/remove-checkbox-tests into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~matsubara/maas/remove-checkbox-tests/+merge/100049

Hi, this branch removes the checkbox tests from the MAAS tree. They'll be kept in the official checkbox repository branch. I updated the docs to point to the official branch and how to run the tests using that branch.

Thanks!
-- 
https://code.launchpad.net/~matsubara/maas/remove-checkbox-tests/+merge/100049
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~matsubara/maas/remove-checkbox-tests into lp:maas.

=== modified file 'HACKING.txt'
--- HACKING.txt	2012-03-28 05:45:01 +0000
+++ HACKING.txt	2012-03-29 22:43:22 +0000
@@ -284,18 +284,19 @@
 ================
 
 MAAS uses checkbox manual testing infrastructure to verify features
-are implemented according to the spec. They can be found in
-the qa/checkbox/ directory.
-
-You need to install checkbox to use those tests::
-
-    $ sudo apt-get install checkbox
-
-To run them::
-
-    $ checkbox-gtk --config='checkbox/plugins/jobs_info/directories=\
-        /path/to/local/checkbox/jobs/dir' --whitelist-file=
-
-or run from the root of the MAAS tree::
-
-    $ make checkbox
+are implemented according to the spec. They can be found in the official
+checkbox repository:
+https://code.launchpad.net/~nskaggs/checkbox/checkbox-app-testing-qt
+in the jobs/ directory.
+
+You need to install additional QT dependencies::
+
+    $ sudo apt-get install libqt4-dev qt4-qmake
+
+Get a copy of the checkbox repository::
+
+    $ bzr branch lp:~nskaggs/checkbox/checkbox-app-testing-qt
+
+To run them, cd into the directory::
+
+    $ bin/checbox-app-testing --whitelist-file=

=== modified file 'Makefile'
--- Makefile	2012-03-23 14:40:42 +0000
+++ Makefile	2012-03-29 22:43:22 +0000
@@ -113,12 +113,8 @@
 	bin/maas migrate maasserver --noinput
 	bin/maas migrate metadataserver --noinput
 
-checkbox: config=checkbox/plugins/jobs_info/directories=$(PWD)/qa/checkbox
-checkbox:
-	checkbox-gtk --config=$(config) --whitelist-file=
-
 .PHONY: \
-    build check checkbox clean dev-db distclean doc \
+    build check clean dev-db distclean doc \
     harness lint pserv-start pserv-stop run \
     txlongpoll-start txlongpoll-stop \
     syncdb test sampledata

=== removed directory 'qa/checkbox'
=== removed file 'qa/checkbox/installer.txt'
--- qa/checkbox/installer.txt	2012-03-15 13:58:32 +0000
+++ qa/checkbox/installer.txt	1970-01-01 00:00:00 +0000
@@ -1,22 +0,0 @@
-plugin: manual
-name: installer/enlist
-description:
- PURPOSE:
-     This will test that the Ubuntu installer has the option to enlist a node from the boot CD.
- STEPS:
-     1. Boot Ubuntu from the CD
-     2. Find the option to enlist the machine to a cloud
- VERIFICATION:
-     Did the installer offer an option to enlist the machine to a cloud?
-
-plugin: manual
-name: installer/server
-description:
- PURPOSE:
-     This will test that the Ubuntu installer has the option to install the MAAS server from the CD.
- STEPS:
-     1. Boot Ubuntu from the CD
-     2. Find the option to install a new MAAS server.
- VERIFICATION:
-     Did the installer offer an option to install a MAAS server?
-

=== removed file 'qa/checkbox/juju.txt'
--- qa/checkbox/juju.txt	2012-03-15 13:58:32 +0000
+++ qa/checkbox/juju.txt	1970-01-01 00:00:00 +0000
@@ -1,22 +0,0 @@
-plugin: manual
-name: juju/bootstrap
-description:
- PURPOSE:
-     This will test that you can bootstrap a Juju environment using a MAAS server.
- STEPS:
-     1. Bootstrap a new environment using juju pointing to a MAAS server.
-     2. Run juju status
- VERIFICATION:
-     Can you use juju status and see the available nodes?
-
-plugin: manual
-name: juju/deploy
-description:
- PURPOSE:
-     This will test that you can succesfully deploy to MAAS nodes using Juju
- STEPS:
-     1. Bootstrap a new environment using juju pointing to a MAAS server.
-     2. Run juju deploy $someservice
- VERIFICATION:
-     Can you use juju deploy $someservice and have it deployed in the MAAS
-     node?

=== removed file 'qa/checkbox/maas.txt'
--- qa/checkbox/maas.txt	2012-03-15 13:58:32 +0000
+++ qa/checkbox/maas.txt	1970-01-01 00:00:00 +0000
@@ -1,27 +0,0 @@
-plugin: manual
-name: maas/update-images
-description:
- PURPOSE:
-     This will test that the MAAS server offers an option to periodically update cloud images.
- STEPS:
-     1. Open the main page to the MAAS server
-     2. Find the option in the MAAS server preferences to periodically update cloud images.
-     3. Set it to automatically update
- VERIFICATION:
-     Did you find the option to periodically update cloud images?
-     Were the cloud images updated according to the schedule?
-
-plugin: manual
-name: maas/cache-archives-locally
-description:
- PURPOSE:
-     This will test that the MAAS server offers an option to cache archives locally.
- STEPS:
-     1. Open the main page to the MAAS server
-     2. Find the option in the MAAS server preferences to cache archives
-     locally
-     3. Enable the option
- VERIFICATION:
-     Did you find the option to cache archives locally?
-     Verify archives are cached locally and nodes are using it to receive updates.
-