launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/maas/bug-969043 into lp:maas has been updated.

Description changed to:

The code that renders ssh keys in a shortened form produces HTML.  But the key's comment (well and to be honest, for all I know the other parts as well) may contain characters that have special meaning in HTML.

Note that escaping the HTML can increase the length of the HTML text, and we can't truncate after escaping because we might truncate inside an entity code.  I don't think it matters, but I mention it for consistency since the code uses the text length of the ellipsis entity code — suggesting that the notion of “size” in this code is based on the number of text characters making up the HTML.

For more details, see:
https://code.launchpad.net/~jtv/maas/bug-969043/+merge/100118
-- 
https://code.launchpad.net/~jtv/maas/bug-969043/+merge/100118
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/bug-969043 into lp:maas.