← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~rvb/maas/maas-admin-approve-nodes-ui into lp:maas

 

Functionally, it works with baremetal. I haven't closely examined the diff, just blackboxed it.  However, i didn't see a 'todo task banner', which i thought this branch might include?  Once i dug into the node page, i found the new button.

"Enlist node" button seems to be overloading a term we've used for the client side of things.  I sort of expected "Accept Enlisted node into MAAS".

Thanks for your hard work on this.
-- 
https://code.launchpad.net/~rvb/maas/maas-admin-approve-nodes-ui/+merge/100176
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/maas-admin-approve-nodes-ui into lp:maas.


Follow ups

References