launchpad-reviewers team mailing list archive

[Raphaël Badin <raphael.badin@xxxxxxxxxxxxx>]

> Functionally, it works with baremetal. I haven't closely examined the diff,
> just blackboxed it.  However, i didn't see a 'todo task banner', which i
> thought this branch might include?  Once i dug into the node page, i found the
> new button.

The "todo task banner" will be in another branch.
 
> "Enlist node" button seems to be overloading a term we've used for the client
> side of things.  I sort of expected "Accept Enlisted node into MAAS".

You've got a point, I'll wait to see what the others have to say about the proper terminology :).


-- 
https://code.launchpad.net/~rvb/maas/maas-admin-approve-nodes-ui/+merge/100176
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/maas-admin-approve-nodes-ui into lp:maas.