launchpad-reviewers team mailing list archive

Thread
Date

[Merge] lp:~wgrant/launchpad/html5-charset into lp:launchpad

To: mp+100541@xxxxxxxxxxxxxxxxxx
From: William Grant <me@xxxxxxxxxxxxxxxxxx>
Date: Tue, 03 Apr 2012 00:50:24 -0000
Reply-to: mp+100541@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

William Grant has proposed merging lp:~wgrant/launchpad/html5-charset into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/html5-charset/+merge/100541

It's generally preferred to specify the document charset in the document itself as well as the headers, so a headerless document (eg. saved locally) is able to be parsed correctly. XML is natively UTF-8, but HTML5 isn't, so we need to use an HTML5 meta charset tag.
-- 
https://code.launchpad.net/~wgrant/launchpad/html5-charset/+merge/100541
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/html5-charset into lp:launchpad.

=== modified file 'lib/lp/app/templates/base-layout.pt'
--- lib/lp/app/templates/base-layout.pt	2012-03-23 20:56:11 +0000
+++ lib/lp/app/templates/base-layout.pt	2012-04-03 00:49:21 +0000
@@ -22,6 +22,7 @@
   xmlns:i18n="http://xml.zope.org/namespaces/i18n";
   xml:lang="en" lang="en" dir="ltr">
   <head>
+    <meta charset="UTF-8" />
     <title tal:content="view/fmt:pagetitle">Page Title</title>
     <link rel="shortcut icon" href="/@@/launchpad.png" />
     <link