launchpad-reviewers team mailing list archive

[Jonathan Lange <jml@xxxxxxxxxxxxx>]

The proposal to merge lp:~jml/launchpad/create-commercial-ppa into lp:launchpad has been updated.

Description changed to:

This branch simply changes the createPPA API such that commercial PPAs can be created as well as private PPAs.

While doing this, we changed the login helpers so that one can easily get the logged in user.  This is particularly helpful when testing with celebrities.  We also added some unit tests for the current PPA creation behaviour, which didn't appear to have unit tests before.

We also discovered a logic bug in validatePPA. We have noted the bug in the code, and would be happy to fix it, but consider such a work separate to the work contained herein.

$ bzr di -r submit: | diffstat
Using parent branch file:///var/launchpad/test/,branch=stable/
 registry/interfaces/person.py        |    2 +-
 registry/model/person.py             |   14 ++++++++++----
 soyuz/interfaces/archive.py          |    2 +-
 soyuz/model/archive.py               |   26 ++++++++++++++++++++------
 soyuz/tests/test_person_createppa.py |   34 ++++++++++++++++++++++++++++++++--
 testing/_login.py                    |    5 +++--
 testing/tests/test_login.py          |   14 ++++++++++++++
 7 files changed, 81 insertions(+), 16 deletions(-)


Thanks,
jml & James Westby

For more details, see:
https://code.launchpad.net/~jml/launchpad/create-commercial-ppa/+merge/100635
-- 
https://code.launchpad.net/~jml/launchpad/create-commercial-ppa/+merge/100635
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jml/launchpad/create-commercial-ppa into lp:launchpad.