launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/maas/preseed-formats-dance into lp:maas has been updated.

Description changed to:

This was going to be my big branch to make preseeds work as desired, with commissioning nodes getting a different format of preseed than other nodes, and patching up all the uncompleted work from my last branch.

Luckily, thanks to the wonders of TDD, all it took was adding some tests and patching up test doubles to work more like the real code.  Yes, one small change in non-testing code but it's entirely cosmetic.

Oh yes, and most of the diff is just moving tests around.  A bunch of helper tests didn't really talk to the pserv API at all and so didn't need to be in tests that could be retargeted against a real pserv etc.

For more details, see:
https://code.launchpad.net/~jtv/maas/preseed-formats-dance/+merge/101012
-- 
https://code.launchpad.net/~jtv/maas/preseed-formats-dance/+merge/101012
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/preseed-formats-dance into lp:maas.