launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

The proposal to merge lp:~cjwatson/launchpad/remove-query-distro-pending-suites into lp:launchpad has been updated.

Description changed to:

== Summary ==

The "pending_suites" action in the lp-query-distro.py script (and the LpQueryDistro script class) made sense when the ftpmaster publisher script was a shell script; pending_suites is used in exactly one place, to discover whether any security suites are pending publication (see r6303.1.2).  However, since it was rewritten in Python, it's just pointless indirection, not to mention inefficient because it means setting up and tearing down a LaunchpadScript instance.  PublishFTPMaster can just talk to the database directly.  We can refactor this.

I also noticed that several other LpQueryDistro actions are no longer used, and removed them; and likewise from a mock version of lp-query-distro.py in use in the cron.germinate tests.  (It probably wouldn't be desperately hard to get rid of the entire script at this point, but that's a matter for another day and another branch.)

== Tests ==

bin/test -vvct test_lpquerydistro -t test_publish_ftpmaster -t test_generate_contents_files -t test_cron_germinate

== lint ==

Just one false positive:

./scripts/ftpmaster-tools/lp-query-distro.py
      23: '_pythonpath' imported but unused

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/remove-query-distro-pending-suites/+merge/101174
-- 
https://code.launchpad.net/~cjwatson/launchpad/remove-query-distro-pending-suites/+merge/101174
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/remove-query-distro-pending-suites into lp:launchpad.