launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

Jeroen T. Vermeulen has proposed merging lp:~jtv/maas/bug-975435 into lp:maas.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #975435 in maas (Ubuntu): "purpose of maas-gc cron job is undocumented"
  https://bugs.launchpad.net/ubuntu/+source/maas/+bug/975435

For more details, see:
https://code.launchpad.net/~jtv/maas/bug-975435/+merge/101331

As reported by Jamie: the maas-gc cron job needs a meaningful description.  No functional change.
-- 
https://code.launchpad.net/~jtv/maas/bug-975435/+merge/101331
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/bug-975435 into lp:maas.

=== modified file 'etc/cron.d/maas-gc'
--- etc/cron.d/maas-gc	2012-04-02 20:14:49 +0000
+++ etc/cron.d/maas-gc	2012-04-10 05:47:18 +0000
@@ -1,2 +1,7 @@
-# Runs 'maas gc' every day at midnight
+# Perform daily background cleanups in MAAS.
+# 
+# The "maas gc" command is for garbage-collection, such as deleting uploaded
+# files that have been overwritten by newer ones.  (This isn't done immediately
+# when the files are overwritten because (1) the transaction that overwrites
+# them may fail, and (2) a file may still be in use when it's overwritten.)
 0 0 * * * root	/usr/sbin/maas gc &> /dev/null