launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/maas/bug-979409 into lp:maas has been updated.

Description changed to:

Scott ran into a little kaboomski while running the reconcile script.  The traceback seemed to make no sense at all, going from ProvisioningProxy (which wraps a remote XMLRPC method) into xmlrpclib (and seemingly, an attempt at invoking a remote method) while looking up the method's name in one of its policy dicts.

Here's what I think happened: the attempt to access method.__name__ tickled the proxy's __getattr__, which is where the tie to the remote method happens.  And so, the attempt to read __name__ went through almost all the motions needed for invoking a remote method.  Not quite all, and it's probably in that difference somewhere that things went haywire.

To avoid the problem, just keep track of the method's name ourselves!  We've got it anyway.  Pass it to the ProvisioningProxy, and done.  This solves Scott's problem.

For more details, see:
https://code.launchpad.net/~jtv/maas/bug-979409/+merge/101665
-- 
https://code.launchpad.net/~jtv/maas/bug-979409/+merge/101665
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/bug-979409 into lp:maas.