launchpad-reviewers team mailing list archive

[Steve Kowalik <stevenk@xxxxxxxxxx>]

Steve Kowalik has proposed merging lp:~stevenk/launchpad/emailaddress-person-required into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~stevenk/launchpad/emailaddress-person-required/+merge/101852

IEmailAddress.person has been NOT NULL in the database since January, make the code agree.
-- 
https://code.launchpad.net/~stevenk/launchpad/emailaddress-person-required/+merge/101852
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stevenk/launchpad/emailaddress-person-required into lp:launchpad.

=== modified file 'lib/lp/services/identity/interfaces/emailaddress.py'
--- lib/lp/services/identity/interfaces/emailaddress.py	2012-01-05 00:23:45 +0000
+++ lib/lp/services/identity/interfaces/emailaddress.py	2012-04-13 02:59:18 +0000
@@ -99,9 +99,9 @@
         title=_('Email Address Status'), required=True, readonly=False,
         vocabulary=EmailAddressStatus)
     person = exported(
-        Reference(title=_('Person'), required=False, readonly=False,
-                  schema=Interface))
-    personID = Int(title=_('PersonID'), required=False, readonly=True)
+        Reference(title=_('Person'), required=True, readonly=False,
+        schema=Interface))
+    personID = Int(title=_('PersonID'), required=True, readonly=True)
 
     rdf_sha1 = TextLine(
         title=_("RDF-ready SHA-1 Hash"),