launchpad-reviewers team mailing list archive

[Jonathan Lange <jml@xxxxxxxxxxxxx>]

Jonathan Lange has proposed merging lp:~jml/launchpad/expose-commercial-on-create-ppa into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #973398 in Launchpad itself: "Cannot create commercial PPAs"
  https://bugs.launchpad.net/launchpad/+bug/973398

For more details, see:
https://code.launchpad.net/~jml/launchpad/expose-commercial-on-create-ppa/+merge/101907

QA revealed that the 'commercial' parameter on createPPA was not being exposed.  This patch exposes it. 

I initially tried to force a test failure by adding something to lp/soyuz/stories/webservice/xx-person-createppa.txt that created a commercial PPA.  Annoyingly, this test passed, so I deleted it.  I couldn't figure out how to get a failing test, so I have just submitted the fix.
-- 
https://code.launchpad.net/~jml/launchpad/expose-commercial-on-create-ppa/+merge/101907
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jml/launchpad/expose-commercial-on-create-ppa into lp:launchpad.

=== modified file 'lib/lp/registry/interfaces/person.py'
--- lib/lp/registry/interfaces/person.py	2012-04-03 15:34:50 +0000
+++ lib/lp/registry/interfaces/person.py	2012-04-13 13:45:25 +0000
@@ -1487,6 +1487,7 @@
         displayname=TextLine(required=False),
         description=TextLine(required=False),
         private=Bool(required=False),
+        commercial=Bool(required=False),
         )
     @export_factory_operation(Interface, [])  # Really IArchive.
     @operation_for_version("beta")