launchpad-reviewers team mailing list archive

["Jeroen T. Vermeulen" <jtv@xxxxxxxxxxxxx>]

The proposal to merge lp:~jtv/maas/bug-984687 into lp:maas has been updated.

Description changed to:

Discussed with Gavin & Raphaël.  This wraps the startup calls to our Twisted apps to clean up their pidfiles when they exit.  In principle Twisted can do this itself, but it's not very thorough.  In particular, this fixes bug 984687: if the service exits immediately on startup because another branch is already running the same service, this won't leave a pointless pidfile in place.

I stole the code for parsing Twisted's options from the wrapped function.  That does mean that we end up parsing the command line twice.  Probably better than replicating twisted's run() function locally just to get at its options object.

Jeroen

For more details, see:
https://code.launchpad.net/~jtv/maas/bug-984687/+merge/102499
-- 
https://code.launchpad.net/~jtv/maas/bug-984687/+merge/102499
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~jtv/maas/bug-984687 into lp:maas.